From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: "Hartley Sweeten" <hsweeten@visionengravers.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v6 24/40] input: keypad: ep93xx: add DT support for Cirrus EP93xx
Date: Wed, 13 Dec 2023 20:41:49 +0200 [thread overview]
Message-ID: <ZXn67cynJdto4lAb@smile.fi.intel.com> (raw)
In-Reply-To: <20231212-ep93xx-v6-24-c307b8ac9aa8@maquefel.me>
On Tue, Dec 12, 2023 at 11:20:41AM +0300, Nikita Shubin wrote:
> - drop flags, they were not used anyway
> - add OF ID match table
> - process "autorepeat", "debounce-delay-ms", prescale from device tree
> - drop platform data usage and it's header
> - keymap goes from device tree now on
...
> static void ep93xx_keypad_config(struct ep93xx_keypad *keypad)
> {
> unsigned int val = 0;
>
> + val |= ((keypad->debounce << KEY_INIT_DBNC_SHIFT) & KEY_INIT_DBNC_MASK);
Since you are touching these lines (see below) you can drop unneeded outer
parentheses.
>
> + val |= ((keypad->prescale << KEY_INIT_PRSCL_SHIFT) & KEY_INIT_PRSCL_MASK);
See above.
> __raw_writel(val, keypad->mmio_base + KEY_INIT);
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-13 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:20 [PATCH v6 00/40] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 23/40] dt-bindings: input: Add Cirrus EP93xx keypad Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 24/40] input: keypad: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2023-12-13 18:41 ` Andy Shevchenko [this message]
2023-12-12 11:53 ` [PATCH v6 00/40] ep93xx device tree conversion Uwe Kleine-König
2023-12-13 17:59 ` Andy Shevchenko
2023-12-23 9:12 ` Nikita Shubin
2023-12-25 19:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXn67cynJdto4lAb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dlemoal@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nikita.shubin@maquefel.me \
--cc=s.shtylyov@omp.ru \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox