* [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
@ 2024-01-27 15:18 Heiner Kallweit
2024-02-03 20:39 ` Wolfram Sang
2024-03-02 17:45 ` Heiner Kallweit
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2024-01-27 15:18 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: open list:HID CORE LAYER, linux-i2c@vger.kernel.org
Class-based I2C probing requires detect() and address_list to be
set in the I2C client driver, see checks in i2c_detect().
It's misleading to declare I2C_CLASS_HWMON support if this
precondition isn't met.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/input/misc/bma150.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
index 0fb4cc628..22feaa8c1 100644
--- a/drivers/input/misc/bma150.c
+++ b/drivers/input/misc/bma150.c
@@ -549,7 +549,6 @@ static struct i2c_driver bma150_driver = {
.name = BMA150_DRIVER,
.pm = &bma150_pm,
},
- .class = I2C_CLASS_HWMON,
.id_table = bma150_id,
.probe = bma150_probe,
.remove = bma150_remove,
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
2024-01-27 15:18 [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
@ 2024-02-03 20:39 ` Wolfram Sang
2024-03-02 17:45 ` Heiner Kallweit
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2024-02-03 20:39 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Dmitry Torokhov, open list:HID CORE LAYER,
linux-i2c@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Sat, Jan 27, 2024 at 04:18:57PM +0100, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
2024-01-27 15:18 [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-02-03 20:39 ` Wolfram Sang
@ 2024-03-02 17:45 ` Heiner Kallweit
1 sibling, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2024-03-02 17:45 UTC (permalink / raw)
To: Dmitry Torokhov, Wolfram Sang
Cc: open list:HID CORE LAYER, linux-i2c@vger.kernel.org
On 27.01.2024 16:18, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
Any feedback here? Should this better go through the I2C tree?
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/input/misc/bma150.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
> index 0fb4cc628..22feaa8c1 100644
> --- a/drivers/input/misc/bma150.c
> +++ b/drivers/input/misc/bma150.c
> @@ -549,7 +549,6 @@ static struct i2c_driver bma150_driver = {
> .name = BMA150_DRIVER,
> .pm = &bma150_pm,
> },
> - .class = I2C_CLASS_HWMON,
> .id_table = bma150_id,
> .probe = bma150_probe,
> .remove = bma150_remove,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-02 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-27 15:18 [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-02-03 20:39 ` Wolfram Sang
2024-03-02 17:45 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).