From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Brenton Simpson <appsforartists@google.com>
Cc: Vicki Pfau <vi@endrift.com>, Hans de Goede <hdegoede@redhat.com>,
Cameron Gutman <aicommander@gmail.com>,
Erica Taylor <rickytaylor26@gmail.com>,
Ismael Ferreras Morezuelas <swyterzone@gmail.com>,
Jonathan Frederick <doublej472@gmail.com>,
Matthias Benkmann <matthias.benkmann@gmail.com>,
Matthias Berndt <matthias_berndt@gmx.de>,
nate@yocom.org, Sam Lantinga <slouken@libsdl.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] Input: xpad - add Lenovo Legion Go controllers
Date: Tue, 30 Jan 2024 14:32:21 -0800 [thread overview]
Message-ID: <Zbl49VAMZx2qrz-p@google.com> (raw)
In-Reply-To: <CAAL3-=-RRWyCbq_B=Lh7tnG2i3MOLL+2bqPOUS54oTC4+vVk_g@mail.gmail.com>
Hi Brenton,
On Fri, Jan 19, 2024 at 12:22:45AM -0800, Brenton Simpson wrote:
> Thanks Vicki. I didn't realize they were meant to be sorted.
Please try avoid top posting.
>
> Would it be appropriate to add comments explaining the sorting? The
> second stanza, in particular, is sorted by the IDs rather than
> lexicographically. If someone sorted it naively, they'd end up with a
> bigger diff than expected.
Yes, we usually sort by VID/PID rather than the name of the device.
>
> It looks like a few others have escaped sorting; for instance,
> "Microsoft X-Box One Elite 2 pad" appears in the wrong place.
Yep, sometimes we mess up.
>
> If Dmitry wants to land this and then follow on with a sort + comment
> commit (or do that first and then rebase this on top), that would be
> great. I can take a stab too if that's helpful.
I applied the patch (moving the entires to the right place). If someone
would send a patch fixing the Elite 2 entry and noting the sorting rules
I'd be happy to apply it.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-01-30 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 17:45 [PATCH] Input: xpad - add Lenovo Legion Go controllers Brenton Simpson
2023-11-16 18:20 ` Hans de Goede
2024-01-18 18:35 ` Brenton Simpson
2024-01-18 18:41 ` Brenton Simpson
2024-01-19 6:16 ` Vicki Pfau
2024-01-19 8:22 ` Brenton Simpson
2024-01-30 22:32 ` Dmitry Torokhov [this message]
2024-01-30 23:19 ` [PATCH] Input: xpad - sort xpad_device by vendor and product ID Brenton Simpson
2024-02-09 18:56 ` Dmitry Torokhov
2024-02-09 19:27 ` Brenton Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbl49VAMZx2qrz-p@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=aicommander@gmail.com \
--cc=appsforartists@google.com \
--cc=doublej472@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.benkmann@gmail.com \
--cc=matthias_berndt@gmx.de \
--cc=nate@yocom.org \
--cc=rickytaylor26@gmail.com \
--cc=slouken@libsdl.org \
--cc=swyterzone@gmail.com \
--cc=trivial@kernel.org \
--cc=vi@endrift.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).