From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: nikita.shubin@maquefel.me
Cc: "Hartley Sweeten" <hsweeten@visionengravers.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v8 23/38] input: keypad: ep93xx: add DT support for Cirrus EP93xx
Date: Mon, 26 Feb 2024 16:42:33 +0200 [thread overview]
Message-ID: <ZdyjWVwYRfASc38I@smile.fi.intel.com> (raw)
In-Reply-To: <20240226-ep93xx-v8-23-3136dca7238f@maquefel.me>
On Mon, Feb 26, 2024 at 10:30:19AM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@maquefel.me>
>
> - drop flags, they were not used anyway
> - add OF ID match table
> - process "autorepeat", "debounce-delay-ms", prescale from device tree
> - drop platform data usage and it's header
> - keymap goes from device tree now on
...
> struct ep93xx_keypad {
> - struct ep93xx_keypad_platform_data *pdata;
> struct input_dev *input_dev;
> struct clk *clk;
> + unsigned int debounce;
> + uint16_t prescale;
In case you need to send a new version note that the indentation of the fields
is different here. Also uint16_t is not the type we expect to see usually
(does the file use it already?). In kernel we have u16.
> void __iomem *mmio_base;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-26 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 7:29 [PATCH v8 00/38] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-02-26 7:30 ` [PATCH v8 22/38] dt-bindings: input: Add Cirrus EP93xx keypad Nikita Shubin via B4 Relay
2024-02-26 7:30 ` [PATCH v8 23/38] input: keypad: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2024-02-26 14:42 ` Andy Shevchenko [this message]
2024-02-26 13:34 ` [PATCH v8 00/38] ep93xx device tree conversion Mark Brown
2024-02-28 8:23 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdyjWVwYRfASc38I@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dlemoal@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nikita.shubin@maquefel.me \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).