Linux Input/HID development
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	linux-input@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] Input: gpio_keys_polled - Suppress deferred probe error for gpio
Date: Tue, 5 Mar 2024 09:11:44 -0800	[thread overview]
Message-ID: <ZedSUJ8PyyQx2r-c@google.com> (raw)
In-Reply-To: <CAHp75Vc2CePCjwvgwNNkccS6fYV1dZam25Rq__6wW1BUr5CFSQ@mail.gmail.com>

On Tue, Mar 05, 2024 at 07:01:02PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 5, 2024 at 12:10 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> 
> ...
> 
> > there are a few other exit paths that could use dev_err_probe(), but IIRC
> > Dmitry isn't a fan of using dev_err_probe() where the return value cannot be
> > EPROBE_DEFER, so I'm only changing this one error path.
> 
> It's not true anymore. He is fine with that API, and please use it.

I would not get ahead of ourselves ;) I still think we could have done
this better by:

1. Having a format option for printing symbolic errors
2. Recording deferral source at supplier level

But yes, I am accepting patches and new drivers using dev_err_probe().

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-03-05 17:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 10:10 [PATCH] Input: gpio_keys_polled - Suppress deferred probe error for gpio Uwe Kleine-König
2024-03-05 10:18 ` Linus Walleij
2024-03-05 17:01 ` Andy Shevchenko
2024-03-05 17:11   ` Dmitry Torokhov [this message]
2024-03-05 17:15 ` Dmitry Torokhov
2024-03-05 17:41   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZedSUJ8PyyQx2r-c@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox