From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: dmitry.torokhov@gmail.com, christophe.jaillet@wanadoo.fr
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: tca6416 remove unused struct 'tca6416_drv_data'
Date: Fri, 24 May 2024 16:58:22 +0000 [thread overview]
Message-ID: <ZlDHLrkv6oHl_EaF@gallifrey> (raw)
In-Reply-To: <20240523002910.492558-1-linux@treblig.org>
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'tca6416_drv_data' is unused since the original
> commit 30ba3ead0576 ("Input: add keypad driver for keys interfaced to
> TCA6416").
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Oops, looks like Christophe got there first!
Dave
> ---
> drivers/input/keyboard/tca6416-keypad.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/input/keyboard/tca6416-keypad.c b/drivers/input/keyboard/tca6416-keypad.c
> index 677bc4baa5d1..b2060229bd0f 100644
> --- a/drivers/input/keyboard/tca6416-keypad.c
> +++ b/drivers/input/keyboard/tca6416-keypad.c
> @@ -32,11 +32,6 @@ static const struct i2c_device_id tca6416_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, tca6416_id);
>
> -struct tca6416_drv_data {
> - struct input_dev *input;
> - struct tca6416_button data[];
> -};
> -
> struct tca6416_keypad_chip {
> uint16_t reg_output;
> uint16_t reg_direction;
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2024-05-24 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 0:29 [PATCH] Input: tca6416 remove unused struct 'tca6416_drv_data' linux
2024-05-24 16:58 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlDHLrkv6oHl_EaF@gallifrey \
--to=linux@treblig.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).