* [PATCH 1/2] input: Add event code for accessibility key
@ 2024-05-23 6:00 Aseda Aboagye
2024-05-23 6:05 ` [PATCH 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
2024-05-28 20:17 ` [PATCH 1/2] input: Add event code for accessibility key Dmitry Torokhov
0 siblings, 2 replies; 4+ messages in thread
From: Aseda Aboagye @ 2024-05-23 6:00 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Dmitry Torokhov, linux-input
HUTRR116 added support for a new usage titled "System Accessibility
Binding" which toggles a system-wide bound accessibility UI or command.
This commit simply adds a new event code for the usage.
Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
---
drivers/hid/hid-debug.c | 1 +
drivers/hid/hid-input.c | 3 +++
include/uapi/linux/input-event-codes.h | 2 ++
3 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index e7ef1ea107c9..7749c81b6227 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -974,6 +974,7 @@ static const char *keys[KEY_MAX + 1] = {
[KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable",
[KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
[KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
+ [KEY_ACCESSIBILITY] = "Accessibility",
[KEY_DICTATE] = "Dictate",
[KEY_MICMUTE] = "MicrophoneMute",
[KEY_BRIGHTNESS_MIN] = "BrightnessMin",
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 851ee86eff32..6d2dbb75ba65 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -829,6 +829,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
switch (usage->hid & 0xf) {
case 0x9: map_key_clear(KEY_MICMUTE); break;
+ case 0xa:
+ map_key_clear(KEY_ACCESSIBILITY);
+ break;
default: goto ignore;
}
break;
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 022a520e31fc..980ef7fefd2b 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -617,6 +617,8 @@
#define KEY_CAMERA_ACCESS_ENABLE 0x24b /* Enables programmatic access to camera devices. (HUTRR72) */
#define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
#define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
+/* Toggles the system bound accessibility UI/command (HUTRR116) */
+#define KEY_ACCESSIBILITY 0x24e
#define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
#define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
base-commit: 5128de84d8fc849400d00f7a6982711f129699ea
--
2.45.1.288.g0e0cd299f1-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] input: Add support for "Do Not Disturb"
2024-05-23 6:00 [PATCH 1/2] input: Add event code for accessibility key Aseda Aboagye
@ 2024-05-23 6:05 ` Aseda Aboagye
2024-05-28 20:18 ` Dmitry Torokhov
2024-05-28 20:17 ` [PATCH 1/2] input: Add event code for accessibility key Dmitry Torokhov
1 sibling, 1 reply; 4+ messages in thread
From: Aseda Aboagye @ 2024-05-23 6:05 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Dmitry Torokhov, linux-input
HUTRR94 added support for a new usage titled "System Do Not Disturb"
which toggles a system-wide Do Not Disturb setting. This commit simply
adds a new event code for the usage.
Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
---
drivers/hid/hid-debug.c | 1 +
drivers/hid/hid-input.c | 11 +++++++++++
include/uapi/linux/input-event-codes.h | 2 ++
3 files changed, 14 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 7749c81b6227..78b2dd10cba2 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -975,6 +975,7 @@ static const char *keys[KEY_MAX + 1] = {
[KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
[KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
[KEY_ACCESSIBILITY] = "Accessibility",
+ [KEY_DONOTDISTURB] = "DoNotDisturb",
[KEY_DICTATE] = "Dictate",
[KEY_MICMUTE] = "MicrophoneMute",
[KEY_BRIGHTNESS_MIN] = "BrightnessMin",
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 6d2dbb75ba65..7fda66f7b437 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -826,6 +826,17 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
break;
}
+ if ((usage->hid & 0xf0) == 0x90) { /* SystemControl*/
+ switch (usage->hid & 0xf) {
+ case 0xb:
+ map_key_clear(KEY_DONOTDISTURB);
+ break;
+ default:
+ goto ignore;
+ }
+ break;
+ }
+
if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
switch (usage->hid & 0xf) {
case 0x9: map_key_clear(KEY_MICMUTE); break;
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 980ef7fefd2b..b8abc239d660 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -619,6 +619,8 @@
#define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
/* Toggles the system bound accessibility UI/command (HUTRR116) */
#define KEY_ACCESSIBILITY 0x24e
+/* Toggles the system-wide "Do Not Disturb" control (HUTRR94)*/
+#define KEY_DONOTDISTURB 0x24f
#define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
#define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
--
2.45.1.288.g0e0cd299f1-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] input: Add event code for accessibility key
2024-05-23 6:00 [PATCH 1/2] input: Add event code for accessibility key Aseda Aboagye
2024-05-23 6:05 ` [PATCH 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
@ 2024-05-28 20:17 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2024-05-28 20:17 UTC (permalink / raw)
To: Aseda Aboagye; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On Thu, May 23, 2024 at 01:00:14AM -0500, Aseda Aboagye wrote:
> HUTRR116 added support for a new usage titled "System Accessibility
> Binding" which toggles a system-wide bound accessibility UI or command.
> This commit simply adds a new event code for the usage.
>
> Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> ---
> drivers/hid/hid-debug.c | 1 +
> drivers/hid/hid-input.c | 3 +++
> include/uapi/linux/input-event-codes.h | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index e7ef1ea107c9..7749c81b6227 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -974,6 +974,7 @@ static const char *keys[KEY_MAX + 1] = {
> [KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable",
> [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> + [KEY_ACCESSIBILITY] = "Accessibility",
> [KEY_DICTATE] = "Dictate",
> [KEY_MICMUTE] = "MicrophoneMute",
> [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 851ee86eff32..6d2dbb75ba65 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -829,6 +829,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
> switch (usage->hid & 0xf) {
> case 0x9: map_key_clear(KEY_MICMUTE); break;
> + case 0xa:
> + map_key_clear(KEY_ACCESSIBILITY);
> + break;
Please keep the style to match with the rest of the file.
> default: goto ignore;
> }
> break;
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 022a520e31fc..980ef7fefd2b 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -617,6 +617,8 @@
> #define KEY_CAMERA_ACCESS_ENABLE 0x24b /* Enables programmatic access to camera devices. (HUTRR72) */
> #define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
> #define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
> +/* Toggles the system bound accessibility UI/command (HUTRR116) */
> +#define KEY_ACCESSIBILITY 0x24e
Please have the comment after the value to match with the rest of the
file (even though it results in a long line).
>
> #define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
> #define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
>
> base-commit: 5128de84d8fc849400d00f7a6982711f129699ea
> --
> 2.45.1.288.g0e0cd299f1-goog
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] input: Add support for "Do Not Disturb"
2024-05-23 6:05 ` [PATCH 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
@ 2024-05-28 20:18 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2024-05-28 20:18 UTC (permalink / raw)
To: Aseda Aboagye; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On Thu, May 23, 2024 at 01:05:38AM -0500, Aseda Aboagye wrote:
> HUTRR94 added support for a new usage titled "System Do Not Disturb"
> which toggles a system-wide Do Not Disturb setting. This commit simply
> adds a new event code for the usage.
>
> Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> ---
> drivers/hid/hid-debug.c | 1 +
> drivers/hid/hid-input.c | 11 +++++++++++
> include/uapi/linux/input-event-codes.h | 2 ++
> 3 files changed, 14 insertions(+)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 7749c81b6227..78b2dd10cba2 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -975,6 +975,7 @@ static const char *keys[KEY_MAX + 1] = {
> [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> [KEY_ACCESSIBILITY] = "Accessibility",
> + [KEY_DONOTDISTURB] = "DoNotDisturb",
> [KEY_DICTATE] = "Dictate",
> [KEY_MICMUTE] = "MicrophoneMute",
> [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 6d2dbb75ba65..7fda66f7b437 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -826,6 +826,17 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> break;
> }
>
> + if ((usage->hid & 0xf0) == 0x90) { /* SystemControl*/
> + switch (usage->hid & 0xf) {
> + case 0xb:
> + map_key_clear(KEY_DONOTDISTURB);
> + break;
> + default:
> + goto ignore;
> + }
> + break;
> + }
> +
> if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
> switch (usage->hid & 0xf) {
> case 0x9: map_key_clear(KEY_MICMUTE); break;
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 980ef7fefd2b..b8abc239d660 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -619,6 +619,8 @@
> #define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
> /* Toggles the system bound accessibility UI/command (HUTRR116) */
> #define KEY_ACCESSIBILITY 0x24e
> +/* Toggles the system-wide "Do Not Disturb" control (HUTRR94)*/
> +#define KEY_DONOTDISTURB 0x24f
Could we have this as KEY_DO_NOT_DISTURB?
Also the same comments as on the previous patch.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-28 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 6:00 [PATCH 1/2] input: Add event code for accessibility key Aseda Aboagye
2024-05-23 6:05 ` [PATCH 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
2024-05-28 20:18 ` Dmitry Torokhov
2024-05-28 20:17 ` [PATCH 1/2] input: Add event code for accessibility key Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).