Re: [PATCH v2 1/2] input: Add event code for accessibility key

[Aseda Aboagye <aaboagye@chromium.org>]

On Tue, May 28, 2024 at 04:31:03PM -0700, Dmitry Torokhov wrote:
> On Tue, May 28, 2024 at 05:44:01PM -0500, Aseda Aboagye wrote:
> > HUTRR116 added support for a new usage titled "System Accessibility
> > Binding" which toggles a system-wide bound accessibility UI or command.
> > This commit simply adds a new event code for the usage.
> > 
> > Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> > ---
> > Changes from v1:
> >  - Modified formatting to match existing code, ignoring checkpatch.pl.
> > 
> >  drivers/hid/hid-debug.c                | 1 +
> >  drivers/hid/hid-input.c                | 1 +
> >  include/uapi/linux/input-event-codes.h | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> > index e7ef1ea107c9..7749c81b6227 100644
> > --- a/drivers/hid/hid-debug.c
> > +++ b/drivers/hid/hid-debug.c
> > @@ -974,6 +974,7 @@ static const char *keys[KEY_MAX + 1] = {
> >         [KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable",
> >         [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> >         [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> > +       [KEY_ACCESSIBILITY] = "Accessibility",
> >         [KEY_DICTATE] = "Dictate",
> >         [KEY_MICMUTE] = "MicrophoneMute",
> >         [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 851ee86eff32..1ecc5ad57b56 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -829,6 +829,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> >                 if ((usage->hid & 0xf0) == 0xa0) {      /* SystemControl */
> >                         switch (usage->hid & 0xf) {
> >                         case 0x9: map_key_clear(KEY_MICMUTE); break;
> > +                       case 0xa: map_key_clear(KEY_ACCESSIBILITY); break;
> >                         default: goto ignore;
> >                         }
> >                         break;
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 022a520e31fc..7ff6eeef1af0 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -617,6 +617,7 @@
> >  #define KEY_CAMERA_ACCESS_ENABLE       0x24b   /* Enables programmatic access to camera devices. (HUTRR72) */
> >  #define KEY_CAMERA_ACCESS_DISABLE      0x24c   /* Disables programmatic access to camera devices. (HUTRR72) */
> >  #define KEY_CAMERA_ACCESS_TOGGLE       0x24d   /* Toggles the current state of the camera access control. (HUTRR72) */
> > +#define KEY_ACCESSIBILITY              0x24e   /* Toggles the system bound accessibility UI/command (HUTRR116) */
> 
> For input:
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Feel free to merge through HID tree.
>
Thank you so much for the review, I really appreciate it!

> Thanks.
> 
> -- 
> Dmitry
--
Aseda Aboagye