* [PATCH v2 1/2] input: Add event code for accessibility key
@ 2024-05-28 22:44 Aseda Aboagye
2024-05-28 22:51 ` [PATCH v2 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
2024-05-28 23:31 ` [PATCH v2 1/2] input: Add event code for accessibility key Dmitry Torokhov
0 siblings, 2 replies; 6+ messages in thread
From: Aseda Aboagye @ 2024-05-28 22:44 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Dmitry Torokhov, linux-input
HUTRR116 added support for a new usage titled "System Accessibility
Binding" which toggles a system-wide bound accessibility UI or command.
This commit simply adds a new event code for the usage.
Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
---
Changes from v1:
- Modified formatting to match existing code, ignoring checkpatch.pl.
drivers/hid/hid-debug.c | 1 +
drivers/hid/hid-input.c | 1 +
include/uapi/linux/input-event-codes.h | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index e7ef1ea107c9..7749c81b6227 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -974,6 +974,7 @@ static const char *keys[KEY_MAX + 1] = {
[KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable",
[KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
[KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
+ [KEY_ACCESSIBILITY] = "Accessibility",
[KEY_DICTATE] = "Dictate",
[KEY_MICMUTE] = "MicrophoneMute",
[KEY_BRIGHTNESS_MIN] = "BrightnessMin",
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 851ee86eff32..1ecc5ad57b56 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -829,6 +829,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
switch (usage->hid & 0xf) {
case 0x9: map_key_clear(KEY_MICMUTE); break;
+ case 0xa: map_key_clear(KEY_ACCESSIBILITY); break;
default: goto ignore;
}
break;
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 022a520e31fc..7ff6eeef1af0 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -617,6 +617,7 @@
#define KEY_CAMERA_ACCESS_ENABLE 0x24b /* Enables programmatic access to camera devices. (HUTRR72) */
#define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
#define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
+#define KEY_ACCESSIBILITY 0x24e /* Toggles the system bound accessibility UI/command (HUTRR116) */
#define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
#define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
base-commit: 5128de84d8fc849400d00f7a6982711f129699ea
--
2.45.1.288.g0e0cd299f1-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] input: Add support for "Do Not Disturb"
2024-05-28 22:44 [PATCH v2 1/2] input: Add event code for accessibility key Aseda Aboagye
@ 2024-05-28 22:51 ` Aseda Aboagye
2024-05-28 23:32 ` Dmitry Torokhov
2024-05-28 23:31 ` [PATCH v2 1/2] input: Add event code for accessibility key Dmitry Torokhov
1 sibling, 1 reply; 6+ messages in thread
From: Aseda Aboagye @ 2024-05-28 22:51 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Dmitry Torokhov, linux-input
HUTRR94 added support for a new usage titled "System Do Not Disturb"
which toggles a system-wide Do Not Disturb setting. This commit simply
adds a new event code for the usage.
Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
---
Changes from v1:
- Modified formatting to match existing code, ignoring checkpatch.pl.
drivers/hid/hid-debug.c | 1 +
drivers/hid/hid-input.c | 8 ++++++++
include/uapi/linux/input-event-codes.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 7749c81b6227..78b2dd10cba2 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -975,6 +975,7 @@ static const char *keys[KEY_MAX + 1] = {
[KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
[KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
[KEY_ACCESSIBILITY] = "Accessibility",
+ [KEY_DONOTDISTURB] = "DoNotDisturb",
[KEY_DICTATE] = "Dictate",
[KEY_MICMUTE] = "MicrophoneMute",
[KEY_BRIGHTNESS_MIN] = "BrightnessMin",
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 1ecc5ad57b56..f023f51b9c08 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -826,6 +826,14 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
break;
}
+ if ((usage->hid & 0xf0) == 0x90) { /* SystemControl*/
+ switch (usage->hid & 0xf) {
+ case 0xb: map_key_clear(KEY_DONOTDISTURB); break;
+ default: goto ignore;
+ }
+ break;
+ }
+
if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
switch (usage->hid & 0xf) {
case 0x9: map_key_clear(KEY_MICMUTE); break;
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 7ff6eeef1af0..c971d542e525 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -618,6 +618,7 @@
#define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
#define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
#define KEY_ACCESSIBILITY 0x24e /* Toggles the system bound accessibility UI/command (HUTRR116) */
+#define KEY_DONOTDISTURB 0x24f /* Toggles the system-wide "Do Not Disturb" control (HUTRR94)*/
#define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
#define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
--
2.45.1.288.g0e0cd299f1-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] input: Add event code for accessibility key
2024-05-28 22:44 [PATCH v2 1/2] input: Add event code for accessibility key Aseda Aboagye
2024-05-28 22:51 ` [PATCH v2 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
@ 2024-05-28 23:31 ` Dmitry Torokhov
2024-05-29 0:08 ` Aseda Aboagye
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2024-05-28 23:31 UTC (permalink / raw)
To: Aseda Aboagye; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On Tue, May 28, 2024 at 05:44:01PM -0500, Aseda Aboagye wrote:
> HUTRR116 added support for a new usage titled "System Accessibility
> Binding" which toggles a system-wide bound accessibility UI or command.
> This commit simply adds a new event code for the usage.
>
> Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> ---
> Changes from v1:
> - Modified formatting to match existing code, ignoring checkpatch.pl.
>
> drivers/hid/hid-debug.c | 1 +
> drivers/hid/hid-input.c | 1 +
> include/uapi/linux/input-event-codes.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index e7ef1ea107c9..7749c81b6227 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -974,6 +974,7 @@ static const char *keys[KEY_MAX + 1] = {
> [KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable",
> [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> + [KEY_ACCESSIBILITY] = "Accessibility",
> [KEY_DICTATE] = "Dictate",
> [KEY_MICMUTE] = "MicrophoneMute",
> [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 851ee86eff32..1ecc5ad57b56 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -829,6 +829,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
> switch (usage->hid & 0xf) {
> case 0x9: map_key_clear(KEY_MICMUTE); break;
> + case 0xa: map_key_clear(KEY_ACCESSIBILITY); break;
> default: goto ignore;
> }
> break;
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 022a520e31fc..7ff6eeef1af0 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -617,6 +617,7 @@
> #define KEY_CAMERA_ACCESS_ENABLE 0x24b /* Enables programmatic access to camera devices. (HUTRR72) */
> #define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
> #define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
> +#define KEY_ACCESSIBILITY 0x24e /* Toggles the system bound accessibility UI/command (HUTRR116) */
For input:
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Feel free to merge through HID tree.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] input: Add support for "Do Not Disturb"
2024-05-28 22:51 ` [PATCH v2 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
@ 2024-05-28 23:32 ` Dmitry Torokhov
2024-05-29 0:06 ` Aseda Aboagye
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2024-05-28 23:32 UTC (permalink / raw)
To: Aseda Aboagye; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On Tue, May 28, 2024 at 05:51:51PM -0500, Aseda Aboagye wrote:
> HUTRR94 added support for a new usage titled "System Do Not Disturb"
> which toggles a system-wide Do Not Disturb setting. This commit simply
> adds a new event code for the usage.
>
> Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> ---
> Changes from v1:
> - Modified formatting to match existing code, ignoring checkpatch.pl.
>
> drivers/hid/hid-debug.c | 1 +
> drivers/hid/hid-input.c | 8 ++++++++
> include/uapi/linux/input-event-codes.h | 1 +
> 3 files changed, 10 insertions(+)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 7749c81b6227..78b2dd10cba2 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -975,6 +975,7 @@ static const char *keys[KEY_MAX + 1] = {
> [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> [KEY_ACCESSIBILITY] = "Accessibility",
> + [KEY_DONOTDISTURB] = "DoNotDisturb",
> [KEY_DICTATE] = "Dictate",
> [KEY_MICMUTE] = "MicrophoneMute",
> [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 1ecc5ad57b56..f023f51b9c08 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -826,6 +826,14 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> break;
> }
>
> + if ((usage->hid & 0xf0) == 0x90) { /* SystemControl*/
> + switch (usage->hid & 0xf) {
> + case 0xb: map_key_clear(KEY_DONOTDISTURB); break;
> + default: goto ignore;
> + }
> + break;
> + }
> +
> if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
> switch (usage->hid & 0xf) {
> case 0x9: map_key_clear(KEY_MICMUTE); break;
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 7ff6eeef1af0..c971d542e525 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -618,6 +618,7 @@
> #define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
> #define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
> #define KEY_ACCESSIBILITY 0x24e /* Toggles the system bound accessibility UI/command (HUTRR116) */
> +#define KEY_DONOTDISTURB 0x24f /* Toggles the system-wide "Do Not Disturb" control (HUTRR94)*/
Please spare a few underscores: KEY_DO_NOT_DISTURB.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] input: Add support for "Do Not Disturb"
2024-05-28 23:32 ` Dmitry Torokhov
@ 2024-05-29 0:06 ` Aseda Aboagye
0 siblings, 0 replies; 6+ messages in thread
From: Aseda Aboagye @ 2024-05-29 0:06 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On Tue, May 28, 2024 at 04:32:34PM -0700, Dmitry Torokhov wrote:
> On Tue, May 28, 2024 at 05:51:51PM -0500, Aseda Aboagye wrote:
> > HUTRR94 added support for a new usage titled "System Do Not Disturb"
> > which toggles a system-wide Do Not Disturb setting. This commit simply
> > adds a new event code for the usage.
> >
> > Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> > ---
> > Changes from v1:
> > - Modified formatting to match existing code, ignoring checkpatch.pl.
> >
> > drivers/hid/hid-debug.c | 1 +
> > drivers/hid/hid-input.c | 8 ++++++++
> > include/uapi/linux/input-event-codes.h | 1 +
> > 3 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> > index 7749c81b6227..78b2dd10cba2 100644
> > --- a/drivers/hid/hid-debug.c
> > +++ b/drivers/hid/hid-debug.c
> > @@ -975,6 +975,7 @@ static const char *keys[KEY_MAX + 1] = {
> > [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> > [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> > [KEY_ACCESSIBILITY] = "Accessibility",
> > + [KEY_DONOTDISTURB] = "DoNotDisturb",
> > [KEY_DICTATE] = "Dictate",
> > [KEY_MICMUTE] = "MicrophoneMute",
> > [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 1ecc5ad57b56..f023f51b9c08 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -826,6 +826,14 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> > break;
> > }
> >
> > + if ((usage->hid & 0xf0) == 0x90) { /* SystemControl*/
> > + switch (usage->hid & 0xf) {
> > + case 0xb: map_key_clear(KEY_DONOTDISTURB); break;
> > + default: goto ignore;
> > + }
> > + break;
> > + }
> > +
> > if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
> > switch (usage->hid & 0xf) {
> > case 0x9: map_key_clear(KEY_MICMUTE); break;
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 7ff6eeef1af0..c971d542e525 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -618,6 +618,7 @@
> > #define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
> > #define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
> > #define KEY_ACCESSIBILITY 0x24e /* Toggles the system bound accessibility UI/command (HUTRR116) */
> > +#define KEY_DONOTDISTURB 0x24f /* Toggles the system-wide "Do Not Disturb" control (HUTRR94)*/
>
> Please spare a few underscores: KEY_DO_NOT_DISTURB.
>
My apologies, I didn't see your reply on v1 before I sent this. I will
address this in the next version.
>
> --
> Dmitry
--
Aseda Aboagye
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] input: Add event code for accessibility key
2024-05-28 23:31 ` [PATCH v2 1/2] input: Add event code for accessibility key Dmitry Torokhov
@ 2024-05-29 0:08 ` Aseda Aboagye
0 siblings, 0 replies; 6+ messages in thread
From: Aseda Aboagye @ 2024-05-29 0:08 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On Tue, May 28, 2024 at 04:31:03PM -0700, Dmitry Torokhov wrote:
> On Tue, May 28, 2024 at 05:44:01PM -0500, Aseda Aboagye wrote:
> > HUTRR116 added support for a new usage titled "System Accessibility
> > Binding" which toggles a system-wide bound accessibility UI or command.
> > This commit simply adds a new event code for the usage.
> >
> > Signed-off-by: Aseda Aboagye <aaboagye@chromium.org>
> > ---
> > Changes from v1:
> > - Modified formatting to match existing code, ignoring checkpatch.pl.
> >
> > drivers/hid/hid-debug.c | 1 +
> > drivers/hid/hid-input.c | 1 +
> > include/uapi/linux/input-event-codes.h | 1 +
> > 3 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> > index e7ef1ea107c9..7749c81b6227 100644
> > --- a/drivers/hid/hid-debug.c
> > +++ b/drivers/hid/hid-debug.c
> > @@ -974,6 +974,7 @@ static const char *keys[KEY_MAX + 1] = {
> > [KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable",
> > [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable",
> > [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle",
> > + [KEY_ACCESSIBILITY] = "Accessibility",
> > [KEY_DICTATE] = "Dictate",
> > [KEY_MICMUTE] = "MicrophoneMute",
> > [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 851ee86eff32..1ecc5ad57b56 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -829,6 +829,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> > if ((usage->hid & 0xf0) == 0xa0) { /* SystemControl */
> > switch (usage->hid & 0xf) {
> > case 0x9: map_key_clear(KEY_MICMUTE); break;
> > + case 0xa: map_key_clear(KEY_ACCESSIBILITY); break;
> > default: goto ignore;
> > }
> > break;
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 022a520e31fc..7ff6eeef1af0 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -617,6 +617,7 @@
> > #define KEY_CAMERA_ACCESS_ENABLE 0x24b /* Enables programmatic access to camera devices. (HUTRR72) */
> > #define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */
> > #define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */
> > +#define KEY_ACCESSIBILITY 0x24e /* Toggles the system bound accessibility UI/command (HUTRR116) */
>
> For input:
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Feel free to merge through HID tree.
>
Thank you so much for the review, I really appreciate it!
> Thanks.
>
> --
> Dmitry
--
Aseda Aboagye
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-29 0:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 22:44 [PATCH v2 1/2] input: Add event code for accessibility key Aseda Aboagye
2024-05-28 22:51 ` [PATCH v2 2/2] input: Add support for "Do Not Disturb" Aseda Aboagye
2024-05-28 23:32 ` Dmitry Torokhov
2024-05-29 0:06 ` Aseda Aboagye
2024-05-28 23:31 ` [PATCH v2 1/2] input: Add event code for accessibility key Dmitry Torokhov
2024-05-29 0:08 ` Aseda Aboagye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).