[PATCH] Adding quirks for 2024 HP Spectre x360 touchpads

[PATCH] Adding quirks for 2024 HP Spectre x360 touchpads

[Jon Moeller]

---
 drivers/hid/hid-multitouch.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 04a014cd2a2f..7a7918191628 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -212,6 +212,7 @@ static void mt_post_parse(struct mt_device *td, struct mt_application *app);
 #define MT_CLS_GOOGLE				0x0111
 #define MT_CLS_RAZER_BLADE_STEALTH		0x0112
 #define MT_CLS_SMART_TECH			0x0113
+#define MT_CLS_HP_SPECTRE_ELAN_HAPTIC		0x0114
 
 #define MT_DEFAULT_MAXCONTACT	10
 #define MT_MAX_MAXCONTACT	250
@@ -396,6 +397,13 @@ static const struct mt_class mt_classes[] = {
 			MT_QUIRK_CONTACT_CNT_ACCURATE |
 			MT_QUIRK_SEPARATE_APP_REPORT,
 	},
+	{ .name = MT_CLS_HP_SPECTRE_ELAN_HAPTIC,
+		.quirks = MT_QUIRK_ALWAYS_VALID |
+			MT_QUIRK_SLOT_IS_CONTACTID |
+			MT_QUIRK_CONTACT_CNT_ACCURATE |
+			MT_QUIRK_CONFIDENCE |
+			MT_QUIRK_WIN8_PTP_BUTTONS,
+	},
 	{ }
 };
 
@@ -1992,6 +2000,12 @@ static const struct hid_device_id mt_devices[] = {
 		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
 			USB_VENDOR_ID_ELAN, 0x3148) },
 
+	{ .driver_data = MT_CLS_HP_SPECTRE_ELAN_HAPTIC,
+		HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x32c8) },
+
+	{ .driver_data = MT_CLS_HP_SPECTRE_ELAN_HAPTIC,
+		HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x310a) },
+
 	/* Elitegroup panel */
 	{ .driver_data = MT_CLS_SERIAL,
 		MT_USB_DEVICE(USB_VENDOR_ID_ELITEGROUP,
-- 
2.44.0

Signed-off-by: Jon Moeller <jon@moeller.io>

Re: [PATCH] Adding quirks for 2024 HP Spectre x360 touchpads

[Jon Moeller]

Is there anything special I need to do to get this merged? I was
hoping this would get worked into 6.10.

On Mon, Apr 29, 2024 at 12:09 AM Jon Moeller <jon@moeller.io> wrote:
>
> ---
>  drivers/hid/hid-multitouch.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 04a014cd2a2f..7a7918191628 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -212,6 +212,7 @@ static void mt_post_parse(struct mt_device *td, struct mt_application *app);
>  #define MT_CLS_GOOGLE                          0x0111
>  #define MT_CLS_RAZER_BLADE_STEALTH             0x0112
>  #define MT_CLS_SMART_TECH                      0x0113
> +#define MT_CLS_HP_SPECTRE_ELAN_HAPTIC          0x0114
>
>  #define MT_DEFAULT_MAXCONTACT  10
>  #define MT_MAX_MAXCONTACT      250
> @@ -396,6 +397,13 @@ static const struct mt_class mt_classes[] = {
>                         MT_QUIRK_CONTACT_CNT_ACCURATE |
>                         MT_QUIRK_SEPARATE_APP_REPORT,
>         },
> +       { .name = MT_CLS_HP_SPECTRE_ELAN_HAPTIC,
> +               .quirks = MT_QUIRK_ALWAYS_VALID |
> +                       MT_QUIRK_SLOT_IS_CONTACTID |
> +                       MT_QUIRK_CONTACT_CNT_ACCURATE |
> +                       MT_QUIRK_CONFIDENCE |
> +                       MT_QUIRK_WIN8_PTP_BUTTONS,
> +       },
>         { }
>  };
>
> @@ -1992,6 +2000,12 @@ static const struct hid_device_id mt_devices[] = {
>                 HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>                         USB_VENDOR_ID_ELAN, 0x3148) },
>
> +       { .driver_data = MT_CLS_HP_SPECTRE_ELAN_HAPTIC,
> +               HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x32c8) },
> +
> +       { .driver_data = MT_CLS_HP_SPECTRE_ELAN_HAPTIC,
> +               HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x310a) },
> +
>         /* Elitegroup panel */
>         { .driver_data = MT_CLS_SERIAL,
>                 MT_USB_DEVICE(USB_VENDOR_ID_ELITEGROUP,
> --
> 2.44.0
>
> Signed-off-by: Jon Moeller <jon@moeller.io>

Re: [PATCH] Adding quirks for 2024 HP Spectre x360 touchpads

[Aseda Aboagye]

On Tue, May 28, 2024 at 11:21:10AM -0700, Jon Moeller wrote:
> Is there anything special I need to do to get this merged? I was
> hoping this would get worked into 6.10.

I think at a minimum, you need to include some description as to what
problem your patch is trying to solve as part of your commit.
Additionally, you probably want to find the relevant maintainers for the
files that you are modifying and add them to the "To:" field.  This
information can be found in the MAINTAINERS file, or you may use the
`get_maintainer.pl` script. It's possible that they may have missed it,
or perhaps are just busy.

https://docs.kernel.org/process/submitting-patches.html may also be of
some help navigating through the submission process.

--
Aseda Aboagye

> On Mon, Apr 29, 2024 at 12:09 AM Jon Moeller <jon@moeller.io> wrote:
> >
> > ---
> >  drivers/hid/hid-multitouch.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >