From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jason Gerecke <killertofu@gmail.com>
Cc: Ping Cheng <pinglinux@gmail.com>,
linux-input@vger.kernel.org,
Aaron Armstrong Skomra <skomra@gmail.com>,
Joshua Dickens <joshua.dickens@wacom.com>,
Joshua Dickens <Joshua@joshua-dickens.com>
Subject: Re: [PATCH] Input: wacom_w8001: Check for string overflow from strscpy calls
Date: Thu, 30 May 2024 16:48:54 -0700 [thread overview]
Message-ID: <ZlkQZsbDKTkzUfE2@google.com> (raw)
In-Reply-To: <CANRwn3SuTjdCCK4YH1ObvsC_gZuythAQ7kSHJP-CiAFw9h5Qcw@mail.gmail.com>
On Thu, May 23, 2024 at 09:51:42AM -0700, Jason Gerecke wrote:
> [...] If you don't like the idea of introducing non-actionable
> warnings, would you be open to a small cleanup patch instead (see
> attached as an example)? There's no particularly good reason to split
> string generation across calls to strscpy and strlcat when a single
> call to snprintf would do, and snprintf is not __must_check on any of
> the kernels we backport to.
Yes, I actually like it much better, applied.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-05-30 23:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 23:43 [PATCH] Input: wacom_w8001: Check for string overflow from strscpy calls joshua
2024-05-20 18:00 ` Ping Cheng
2024-05-20 23:28 ` Dmitry Torokhov
2024-05-21 3:55 ` Ping Cheng
2024-05-22 17:23 ` Dmitry Torokhov
2024-05-23 16:51 ` Jason Gerecke
2024-05-30 23:48 ` Dmitry Torokhov [this message]
2024-06-05 16:46 ` [PATCH] Input: wacom_w8001: Correct device name generation Gerecke, Jason
2024-06-06 21:09 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlkQZsbDKTkzUfE2@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Joshua@joshua-dickens.com \
--cc=joshua.dickens@wacom.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox