From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daisuke Nojiri <dnojiri@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Reka Norman <rekanorman@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Gwendal Grignou <gwendal@chromium.org>,
Pavan Holla <pholla@chromium.org>,
Lukasz Majczak <lma@chromium.org>,
Ching-Kang Yen <chingkang@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] cros_ec_proto: Consolidate ec_response_get_next_event
Date: Thu, 27 Jun 2024 16:58:26 -0700 [thread overview]
Message-ID: <Zn38onz6Dm4Pt4DH@google.com> (raw)
In-Reply-To: <fc251d6935c1cfc39d7a31d3cfe735d31a0371d1.1719531519.git.dnojiri@chromium.org>
On Thu, Jun 27, 2024 at 04:53:07PM -0700, Daisuke Nojiri wrote:
> Consolidate struct ec_response_get_next_event_v*.
>
> Let X->Y indicate kernel X sending EC_CMD_GET_NEXT_EVENT to FW Y.
>
> Old->New:
> Existing kernels send a smaller container (e.g.
> ec_response_get_next_data) which may or may not fit the last few
> bytes. The FW copies as many bytes as possible to the container. The
> kernel processes as many leading bytes as it can understand.
>
> New->Old:
> New kernels send a bigger container. Existing FW copies as many bytes
> as it wants, leaving the last few bytes empty. The kernel knows it
> didn't receive full size data from the returned data length.
>
> Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-06-27 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 23:53 [PATCH v5 0/2] Consolidate ec_response_get_next_event Daisuke Nojiri
2024-06-27 23:53 ` [PATCH v5 1/2] cros_ec_proto: " Daisuke Nojiri
2024-06-27 23:58 ` Dmitry Torokhov [this message]
2024-06-28 3:00 ` Tzung-Bi Shih
2024-06-29 13:41 ` kernel test robot
2024-06-27 23:53 ` [PATCH v5 2/2] dt-bindings: cros-ec-keyboard: Add keyboard matrix v3.0 Daisuke Nojiri
2024-06-27 23:58 ` Dmitry Torokhov
2024-06-28 7:20 ` Krzysztof Kozlowski
2024-06-30 12:17 ` Tzung-Bi Shih
2024-07-01 1:35 ` Dmitry Torokhov
2024-07-01 3:49 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn38onz6Dm4Pt4DH@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=chingkang@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dnojiri@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lma@chromium.org \
--cc=pholla@chromium.org \
--cc=pmalani@chromium.org \
--cc=rekanorman@chromium.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).