From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D9D83C3C; Fri, 28 Jun 2024 03:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719543657; cv=none; b=k98ctgtfKoDtcedUmOLCdBhV9LWBSG5LDmu2E/tdbRWo+hgA3+olQMMCNUQEsjnY7BKOCDM0oCMpwcNaaSEc2/nRsngImBQaiqG1Mi0bgbu7VX8Gmd3MPsiWZVXYJ8LQEcXTR/cSCDaUKeBxwmPtRux266r8D3n0gX/COtAcnsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719543657; c=relaxed/simple; bh=DkmVFzIEUy4/EhH4jI1kRN0AcPesnvhyjVO39S2JJTs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G2qTnECdHWEaxcbqfAK8nxh5ZOaYfu16jBDhM7RBxGFkOnsbRMqFxNnFkkWSfaYaK9lul0zrfMMaaCZ5qewLCw1m6tBycDQMavmFTIHcCMbN6scu6NAPeCQCDE3Ma/smaxblUV07d7w0u6WPqlxBPufvppY3YlkM4xKLeVaETik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RsgjUevz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RsgjUevz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D46EC2BBFC; Fri, 28 Jun 2024 03:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719543656; bh=DkmVFzIEUy4/EhH4jI1kRN0AcPesnvhyjVO39S2JJTs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RsgjUevzE3HqxEmrKCMLUPKCwxMZtYPJPqihDvl/DsEoPWvzGgJIfN3OfDBHx1zZn hWh8kSYoLEE0+WYsR/B4lp+jwOiVaRN9Ndt7zB1QSRIqAgIKR3O/C7vdYT+R3xMeu5 0yUvy56RjFL8PGZt/LiKJ9yyRTT6ntqeW5uNt8Cop+V198aFJCiAiGqfTr2QDZUV9U 6IgzwAMWnlYXad1Nt+2rBkdeOlvcppSZ6lC+1EB+lMr7xw0zEPiNqHpG/I2BK/wf9Q U+mn9LN9ndxN0sYaUSxpanptEd+2nSPOsnT80vLyGVECAJIwN6fg8By2EL4w67RJcb tT+E4Yi2bGWNQ== Date: Fri, 28 Jun 2024 11:00:49 +0800 From: Tzung-Bi Shih To: Daisuke Nojiri Cc: Benson Leung , Guenter Roeck , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Reka Norman , Hans Verkuil , Gwendal Grignou , Pavan Holla , Lukasz Majczak , Ching-Kang Yen , Stephen Boyd , Prashant Malani , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/2] cros_ec_proto: Consolidate ec_response_get_next_event Message-ID: References: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 27, 2024 at 04:53:07PM -0700, Daisuke Nojiri wrote: Your previous patches have been applied to for-next branch: ba098ed9829c ("platform/chrome: Add struct ec_response_get_next_event_v3") 106d67398233 ("platform/chrome: cros_ec_proto: Upgrade get_next_event to v3") Please send incremental patches based on for-next. > Consolidate struct ec_response_get_next_event_v*. > > Let X->Y indicate kernel X sending EC_CMD_GET_NEXT_EVENT to FW Y. > > Old->New: > Existing kernels send a smaller container (e.g. > ec_response_get_next_data) which may or may not fit the last few > bytes. The FW copies as many bytes as possible to the container. The > kernel processes as many leading bytes as it can understand. > > New->Old: > New kernels send a bigger container. Existing FW copies as many bytes > as it wants, leaving the last few bytes empty. The kernel knows it > didn't receive full size data from the returned data length. > > Signed-off-by: Daisuke Nojiri > --- > drivers/platform/chrome/cros_ec_proto.c | 16 ++++----- > .../linux/platform_data/cros_ec_commands.h | 34 +------------------ NACK, we don't do it: diverging cros_ec_commands.h and EC's ec_commands.h.