* [PATCH 1/1] Input: ads7846 - Use spi_device_id table
@ 2024-06-19 12:27 Alexander Stein
2024-06-20 15:42 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2024-06-19 12:27 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Alexander Stein, linux-input, linux-kernel
As the driver supports more devices over time the single MODULE_ALIAS
is complete and raises several warnings:
SPI driver ads7846 has no spi_device_id for ti,tsc2046
SPI driver ads7846 has no spi_device_id for ti,ads7843
SPI driver ads7846 has no spi_device_id for ti,ads7845
SPI driver ads7846 has no spi_device_id for ti,ads7873
Fix this by adding a spi_device_id table and removing the manual
MODULE_ALIAS.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/input/touchscreen/ads7846.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index d2bbb436a77df..4d13db13b9e57 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -1111,6 +1111,16 @@ static const struct of_device_id ads7846_dt_ids[] = {
};
MODULE_DEVICE_TABLE(of, ads7846_dt_ids);
+static const struct spi_device_id ads7846_spi_ids[] = {
+ { "tsc2046", 7846 },
+ { "ads7843", 7843 },
+ { "ads7845", 7845 },
+ { "ads7846", 7846 },
+ { "ads7873", 7873 },
+ { },
+};
+MODULE_DEVICE_TABLE(spi, ads7846_spi_ids);
+
static const struct ads7846_platform_data *ads7846_get_props(struct device *dev)
{
struct ads7846_platform_data *pdata;
@@ -1386,10 +1396,10 @@ static struct spi_driver ads7846_driver = {
},
.probe = ads7846_probe,
.remove = ads7846_remove,
+ .id_table = ads7846_spi_ids,
};
module_spi_driver(ads7846_driver);
MODULE_DESCRIPTION("ADS7846 TouchScreen Driver");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("spi:ads7846");
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Input: ads7846 - Use spi_device_id table
2024-06-19 12:27 [PATCH 1/1] Input: ads7846 - Use spi_device_id table Alexander Stein
@ 2024-06-20 15:42 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2024-06-20 15:42 UTC (permalink / raw)
To: Alexander Stein; +Cc: linux-input, linux-kernel
On Wed, Jun 19, 2024 at 02:27:02PM +0200, Alexander Stein wrote:
> As the driver supports more devices over time the single MODULE_ALIAS
> is complete and raises several warnings:
> SPI driver ads7846 has no spi_device_id for ti,tsc2046
> SPI driver ads7846 has no spi_device_id for ti,ads7843
> SPI driver ads7846 has no spi_device_id for ti,ads7845
> SPI driver ads7846 has no spi_device_id for ti,ads7873
>
> Fix this by adding a spi_device_id table and removing the manual
> MODULE_ALIAS.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-20 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 12:27 [PATCH 1/1] Input: ads7846 - Use spi_device_id table Alexander Stein
2024-06-20 15:42 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).