linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: James Ogletree <jogletre@opensource.cirrus.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, lee@kernel.org, broonie@kernel.org,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND v11 4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver
Date: Sun, 23 Jun 2024 01:02:33 -0700	[thread overview]
Message-ID: <ZnfWmR48MfcQKpTS@google.com> (raw)
In-Reply-To: <ZndqwfN4G+RkCNrn@nixie71>

On Sat, Jun 22, 2024 at 07:22:25PM -0500, Jeff LaBundy wrote:
> Hi James,
> 
> On Thu, Jun 20, 2024 at 04:17:44PM +0000, James Ogletree wrote:
> > Introduce support for Cirrus Logic Device CS40L50: a
> > haptic driver with waveform memory, integrated DSP,
> > and closed-loop algorithms.
> > 
> > The input driver provides the interface for control of
> > haptic effects through the device.
> > 
> > Signed-off-by: James Ogletree <jogletre@opensource.cirrus.com>
> 
> Reviewed-by: Jeff LaBundy <jeff@labundy.com>

OK, let's merge it.

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

IMO it still needs improvements so that the repeated effect can be
stopped/erased without waiting for it to finish playing, but that
can be improved later.

I assume it is going through MFD tree?

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-06-23  8:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 16:17 [PATCH RESEND v11 0/5] Add support for CS40L50 James Ogletree
2024-06-20 16:17 ` [PATCH RESEND v11 1/5] firmware: cs_dsp: Add write sequence interface James Ogletree
2024-06-23  0:19   ` Jeff LaBundy
2024-06-20 16:17 ` [PATCH RESEND v11 2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding James Ogletree
2024-06-23  0:20   ` Jeff LaBundy
2024-06-20 16:17 ` [PATCH RESEND v11 3/5] mfd: cs40l50: Add support for CS40L50 core driver James Ogletree
2024-06-23  0:21   ` Jeff LaBundy
2024-06-20 16:17 ` [PATCH RESEND v11 4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver James Ogletree
2024-06-23  0:22   ` Jeff LaBundy
2024-06-23  8:02     ` Dmitry Torokhov [this message]
2024-06-23 19:04       ` James Ogletree
2024-06-20 16:17 ` [PATCH RESEND v11 5/5] ASoC: cs40l50: Support I2S streaming to CS40L50 James Ogletree
2024-06-23  0:23   ` Jeff LaBundy
2024-06-26 16:55   ` Rivera-Matos, Ricardo
2024-06-20 16:59 ` [PATCH RESEND v11 0/5] Add support for CS40L50 Lee Jones
2024-06-26 20:35   ` James Ogletree
2024-06-27  7:12     ` Lee Jones
2024-06-27 12:07       ` James Ogletree
2024-06-28  8:06         ` Lee Jones
2024-06-28 11:18           ` James Ogletree
2024-06-28 14:23             ` Lee Jones
2024-06-28 14:36 ` Lee Jones
2024-06-28 14:38   ` Lee Jones
2024-06-28 14:38     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnfWmR48MfcQKpTS@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jeff@labundy.com \
    --cc=jogletre@opensource.cirrus.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).