From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Caleb Connolly <caleb@postmarketos.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Henrik Rydberg <rydberg@bitmath.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/7] dt-bindings: input: touchscreen: document synaptics TCM oncell
Date: Mon, 24 Jun 2024 00:25:08 -0700 [thread overview]
Message-ID: <ZnkfVAfubwFFydpt@google.com> (raw)
In-Reply-To: <20240624-oneplus8-v1-2-388eecf2dff7@postmarketos.org>
Hi Caleb,
On Mon, Jun 24, 2024 at 03:30:26AM +0200, Caleb Connolly wrote:
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + touchscreen@4b {
> + compatible = "syna,s3908";
> + reg = <0x4B>;
> +
> + interrupts-extended = <&tlmm 39 0x2008>;
> +
> + reset-gpios = <&tlmm 38 GPIO_ACTIVE_HIGH>;
This shows wrong default polarity. It should be GPIO_ACTIVE_LOW.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-06-24 7:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 1:30 [PATCH 0/7] qcom: initial support for the OnePlus 8T Caleb Connolly
2024-06-24 1:30 ` [PATCH 1/7] dt-bindings: panel: document Samsung AMB655X Caleb Connolly
2024-06-24 1:33 ` Caleb Connolly
2024-06-27 22:12 ` Rob Herring
2024-06-27 23:24 ` Caleb Connolly
2024-06-24 1:30 ` [PATCH 2/7] dt-bindings: input: touchscreen: document synaptics TCM oncell Caleb Connolly
2024-06-24 2:42 ` Rob Herring (Arm)
2024-06-24 7:25 ` Dmitry Torokhov [this message]
2024-06-24 1:30 ` [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series Caleb Connolly
2024-06-24 4:52 ` Krzysztof Kozlowski
2024-06-24 20:40 ` Rob Herring
2024-06-24 1:30 ` [PATCH 4/7] drm: mipi: add mipi_dsi_generic_write_multi_type() Caleb Connolly
2024-06-24 5:21 ` Dmitry Baryshkov
2024-06-24 1:30 ` [PATCH 5/7] drm/panel: add driver for samsung amb655x Caleb Connolly
2024-06-24 5:31 ` Dmitry Baryshkov
2024-06-24 1:30 ` [PATCH 6/7] Input: touchscreen: add Synaptics TCM oncell S3908 Caleb Connolly
2024-06-24 7:42 ` Dmitry Torokhov
2024-06-27 23:35 ` Caleb Connolly
2024-06-24 1:30 ` [PATCH 7/7] arm64: dts: qcom: add OnePlus 8T (kebab) Caleb Connolly
2024-06-26 4:16 ` Bjorn Andersson
2024-06-27 23:40 ` Caleb Connolly
2024-06-26 9:43 ` Konrad Dybcio
2024-06-24 5:18 ` [PATCH 0/7] qcom: initial support for the OnePlus 8T Dmitry Baryshkov
2024-06-24 11:32 ` Caleb Connolly
2024-06-24 11:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnkfVAfubwFFydpt@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=caleb@postmarketos.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
--cc=tzimmermann@suse.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).