From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <bentiss@kernel.org>
Cc: linux-input@vger.kernel.org, Jeff LaBundy <jeff@labundy.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Input: simplify event handling logic
Date: Mon, 1 Jul 2024 09:31:28 -0700 [thread overview]
Message-ID: <ZoLZ4INw2gZjNzw1@google.com> (raw)
In-Reply-To: <qevkkesgw7y2bypexmogght7iozo646vowjkovht5mplegzvnl@tzfffoaglijz>
On Mon, Jul 01, 2024 at 09:41:22AM +0200, Benjamin Tissoires wrote:
> On Jun 30 2024, Dmitry Torokhov wrote:
> > /*
> > * Pass values first through all filters and then, if event has not been
> > * filtered out, through all open handles. This function is called with
>
> Nitpick: maybe that comment above input_pass_values() should also be
> amended now that the processing is more straightforward?
I think the comment is still accurate from the higher POV. We do want to
send the event(s) first through all the filters and the remainder is
through the handlers. This is achieved by placing filters at the head of
the list of handles attacher to the device, and placing regular handles
at the tail of the list.
Do you want me to expand the comment?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-07-01 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 6:05 [PATCH 0/4] Simplify event handling logic in input core Dmitry Torokhov
2024-07-01 6:05 ` [PATCH 1/4] Input: make sure input handlers define only one processing method Dmitry Torokhov
2024-07-01 7:36 ` Benjamin Tissoires
2024-07-01 16:26 ` Dmitry Torokhov
2024-07-01 6:05 ` [PATCH 2/4] Input: make events() method return number of events processed Dmitry Torokhov
2024-07-01 7:37 ` Benjamin Tissoires
2024-07-01 6:05 ` [PATCH 3/4] Input: simplify event handling logic Dmitry Torokhov
2024-07-01 7:41 ` Benjamin Tissoires
2024-07-01 16:31 ` Dmitry Torokhov [this message]
2024-07-01 17:54 ` Benjamin Tissoires
2024-07-01 6:05 ` [PATCH 4/4] Input: preallocate memory to hold event values Dmitry Torokhov
2024-07-01 7:53 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoLZ4INw2gZjNzw1@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bentiss@kernel.org \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).