linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: linux-input@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] Input - Drop explicit initialization of struct i2c_device_id::driver_data to 0
Date: Mon, 1 Jul 2024 15:58:28 -0700	[thread overview]
Message-ID: <ZoM0lM4uLdNjO_d_@google.com> (raw)
In-Reply-To: <ZoM0Ttysx91ZemKS@google.com>

[ resending to the right address ]

On Mon, Jul 01, 2024 at 03:57:18PM -0700, Dmitry Torokhov wrote:
> On Mon, May 13, 2024 at 03:53:27PM -0700, Dmitry Torokhov wrote:
> > On Thu, May 09, 2024 at 07:41:59PM +0200, Uwe Kleine-König wrote:
> > > These drivers don't use the driver_data member of struct i2c_device_id,
> > > so don't explicitly initialize this member.
> > > 
> > > This prepares putting driver_data in an anonymous union which requires
> > > either no initialization or named designators. But it's also a nice
> > > cleanup on its own.
> > > 
> > > While add it, also remove commas after the sentinel entries.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > Applied, thank you.
> 
> Uwe, could you share the end goal here? It looks like there are couple
> of efforts to deal with driver matching data, for example I had this
> proposal (which I did not pursue further so far):
> 
> https://lore.kernel.org/all/20230814-i2c-id-rework-v1-0-3e5bc71c49ee@gmail.com/
> 
> I think it would be good for all of use to be on the same page.
> 
> Thanks.
> 
> -- 
> Dmitry

-- 
Dmitry

  reply	other threads:[~2024-07-01 22:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 17:41 [PATCH] Input - Drop explicit initialization of struct i2c_device_id::driver_data to 0 Uwe Kleine-König
2024-05-13 22:53 ` Dmitry Torokhov
2024-07-01 22:57   ` Dmitry Torokhov
2024-07-01 22:58     ` Dmitry Torokhov [this message]
2024-07-02 10:19     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoM0lM4uLdNjO_d_@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-input@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).