From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-input@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel@dh-electronics.com
Subject: Re: [PATCH] Input: ads7846 - ratelimit the spi_sync error message
Date: Tue, 23 Jul 2024 21:10:58 -0700 [thread overview]
Message-ID: <ZqB-0kn_zN2Bdeaj@google.com> (raw)
In-Reply-To: <ef0cb137-5155-4956-bda0-70757a05066c@denx.de>
On Thu, Jul 18, 2024 at 02:02:50AM +0200, Marek Vasut wrote:
> On 7/8/24 11:39 PM, Dmitry Torokhov wrote:
> > On July 8, 2024 2:18:57 PM PDT, Marek Vasut <marex@denx.de> wrote:
> > > In case the touch controller is not connected, this message keeps scrolling
> > > on the console indefinitelly. Ratelimit it to avoid filling kernel logs.
> >
> > Instead of ratelimiting, maybe we should try reading touchscreen state when
> > probing and abort if the device dies not respond?
>
> Ratelimiting also helps if the touch controller fails or disconnects at
> runtime, which would still trigger the scrolling messages. With this cheap
> prototype hardware, that happens.
OK, fair enough. Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2024-07-24 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 21:18 [PATCH] Input: ads7846 - ratelimit the spi_sync error message Marek Vasut
2024-07-08 21:39 ` Dmitry Torokhov
2024-07-18 0:02 ` Marek Vasut
2024-07-24 4:10 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqB-0kn_zN2Bdeaj@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@dh-electronics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).