From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Henrik Rydberg <rydberg@bitmath.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH (resend)] Input: MT - limit max slots
Date: Mon, 29 Jul 2024 11:35:28 -0700 [thread overview]
Message-ID: <Zqfg8FW-SFFedebo@google.com> (raw)
In-Reply-To: <CAHk-=wiT8RzFUVXe=r3S9dfCpV+FhARgtb5SxLDSOKCJKCLOZA@mail.gmail.com>
On Mon, Jul 29, 2024 at 11:16:02AM -0700, Linus Torvalds wrote:
> On Mon, 29 Jul 2024 at 10:59, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> > Can I write a gigabyte of data to disk? Terabyte? Is petabyte too much?
> > What if I don't have enough physical disk. Do we "fix" write() not to
> > take size_t length?
>
> Dmitry, that's *EXACTLY* what we did decades ago.
What exactly did you do? Limit size of data userspace can request to be
written? What is the max allowed size then? Can I stick a warning in the
code to complain when it is "too big"?
>
> Your argument is bogus garbage. We do various arbitrary limits exactly
> to head off problems early.
So does this mean that we should disallow any and all allocations above
4k because they can potentially fail, depending on the system state? Or
maybe we should be resilient and fail gracefully instead?
It would help if you expanded why exactly my argument is a garbage and
what the problem is with recognizing that memory is a depletable
resource (like a lot of other resources, including storage) and there's
never a "completely safe" amount that can be used, so trying to
introduce it is futile.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-07-29 18:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 12:51 [PATCH (resend)] Input: MT - limit max slots Tetsuo Handa
2024-07-29 13:05 ` Greg Kroah-Hartman
2024-07-29 13:15 ` Tetsuo Handa
2024-07-29 14:28 ` Greg Kroah-Hartman
2024-07-29 15:57 ` Dmitry Torokhov
2024-07-29 17:43 ` Linus Torvalds
2024-07-29 17:59 ` Dmitry Torokhov
2024-07-29 18:16 ` Linus Torvalds
2024-07-29 18:35 ` Dmitry Torokhov [this message]
2024-07-29 18:41 ` Linus Torvalds
2024-07-29 19:12 ` Dmitry Torokhov
2024-07-29 19:27 ` Linus Torvalds
2024-07-29 20:00 ` Dmitry Torokhov
2024-07-29 20:14 ` Linus Torvalds
2024-07-29 23:17 ` Dmitry Torokhov
2024-07-30 5:38 ` Tetsuo Handa
2024-07-30 21:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqfg8FW-SFFedebo@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rydberg@bitmath.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).