From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Trilok Soni <quic_tsoni@quicinc.com>,
Felipe Balbi <balbi@kernel.org>, Tony Lindgren <tony@atomide.com>,
Arnd Bergmann <arnd@arndb.de>,
wsa@kernel.org
Subject: lm8323/lm8333 keyboard drivers - drop or keep?
Date: Thu, 15 Aug 2024 16:02:13 -0700 [thread overview]
Message-ID: <Zr6I9RB5mibU_12N@google.com> (raw)
Hi,
LM8323 and LM8333 keyboard drivers do not appear to be used anywhere,
they only support configuration via platform data and refuse to work
without it, and nothing in the mainline sets up said platform data.
LM8323 I think was used in Nokia N810, but despite presence of
arch/arm/boot/dts/omap2420-n810.dts the device is not mentioned there
and the driver has not been updated to support device tree.
Additionally LM8323 seems to be pretty broken as far as PWM/LED handling
is concerned (taking mutexes in set_brightness() which should not be
sleeping) which suggests that nobody ever used it (or at least not used
the version that is in mainline).
Should either of these drivers be dropped? Or if it should be kept -
why?
Thanks.
--
Dmitry
next reply other threads:[~2024-08-15 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 23:02 Dmitry Torokhov [this message]
2024-08-15 23:30 ` lm8323/lm8333 keyboard drivers - drop or keep? Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr6I9RB5mibU_12N@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tsoni@quicinc.com \
--cc=tony@atomide.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).