lm8323/lm8333 keyboard drivers - drop or keep?

lm8323/lm8333 keyboard drivers - drop or keep?

[Dmitry Torokhov]

Hi,

LM8323 and LM8333 keyboard drivers do not appear to be used anywhere,
they only support configuration via platform data and refuse to work
without it, and nothing in the mainline sets up said platform data.

LM8323 I think was used in Nokia N810, but despite presence of
arch/arm/boot/dts/omap2420-n810.dts the device is not mentioned there
and the driver has not been updated to support device tree.

Additionally LM8323 seems to be pretty broken as far as PWM/LED handling
is concerned (taking mutexes in set_brightness() which should not be
sleeping) which suggests that nobody ever used it (or at least not used
the version that is in mainline).

Should either of these drivers be dropped? Or if it should be kept -
why?

Thanks.

-- 
Dmitry

Re: lm8323/lm8333 keyboard drivers - drop or keep?

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi Dmitry,

> Should either of these drivers be dropped? Or if it should be kept -
> why?

LM8333, that was a while ago! We definitely used the driver in a BSP,
back then at Pengutronix. I left the company shortly after and it seems
the board file was never upstreamed.

So, your call to remove it or not. Since the driver hasn't been
converted to DT yet, it probably never will. I agree to that.

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]