From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: linux-input@vger.kernel.org, Jeff LaBundy <jeff@labundy.com>,
Benjamin Tissoires <bentiss@kernel.org>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] Input: evdev - limit amount of data for writes
Date: Thu, 15 Aug 2024 23:17:19 -0700 [thread overview]
Message-ID: <Zr7u78IvuiwbmxYZ@google.com> (raw)
In-Reply-To: <20240816001805.GA232957@quokka>
On Fri, Aug 16, 2024 at 10:18:05AM +1000, Peter Hutterer wrote:
> On Thu, Aug 15, 2024 at 11:41:53AM -0700, Dmitry Torokhov wrote:
> > Limit amount of data that can be written into an evdev instance at
> > a given time to 4096 bytes (170 input events) to avoid holding
> > evdev->mutex for too long and starving other users.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> I'd expect anything coming near 170 input events is going to trigger
> SYN_DROPPED anyway, so:
This actually going the other direction (userspace -> kernel) so there
will be no SYN_DROPPED, at least on the way in.
>
> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Thanks for the review!
--
Dmitry
next prev parent reply other threads:[~2024-08-16 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 18:41 [PATCH] Input: evdev - limit amount of data for writes Dmitry Torokhov
2024-08-16 0:18 ` Peter Hutterer
2024-08-16 6:17 ` Dmitry Torokhov [this message]
2024-08-18 5:47 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr7u78IvuiwbmxYZ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bentiss@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).