From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Nikita Travkin <nikita@trvn.ru>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: zinitix - Read and cache device version numbers
Date: Mon, 5 Aug 2024 17:18:58 -0700 [thread overview]
Message-ID: <ZrFr8k5b7VvC7h50@google.com> (raw)
In-Reply-To: <20240806-zinitix-tk-versions-v1-1-63ef79c7f2a1@linaro.org>
Hi Linus,
On Tue, Aug 06, 2024 at 12:11:38AM +0200, Linus Walleij wrote:
> static int zinitix_init_touch(struct bt541_ts_data *bt541)
> {
> struct i2c_client *client = bt541->client;
> int i;
> int error;
> u16 int_flags;
> + static bool read_static = false;
As I mentioned before using such static flags is not the best practice,
can it be moved into per-device structure?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-08-06 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 22:11 [PATCH 0/2] Input: zinitix - Handle chip revisions for touchkeys Linus Walleij
2024-08-05 22:11 ` [PATCH 1/2] Input: zinitix - Read and cache device version numbers Linus Walleij
2024-08-06 0:18 ` Dmitry Torokhov [this message]
2024-08-05 22:11 ` [PATCH 2/2] Input: zinitix - Varying icon status registers Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrFr8k5b7VvC7h50@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=nikita@trvn.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).