public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Wang <charles.goodix@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: dmitry.torokhov@gmail.com, dan.carpenter@linaro.org,
	conor@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	jikos@kernel.org, bentiss@kernel.org, hbarnor@chromium.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Date: Wed, 14 Aug 2024 10:37:17 +0800	[thread overview]
Message-ID: <ZrwYXajn3a6R8VOm@ux-UP-WHL01> (raw)
In-Reply-To: <CAD=FV=WLse_tiiMr8t7Kq0EguzJtt4iqhr6cPUvuDcy8MT0k7Q@mail.gmail.com>

Hi Doug

Sorry for missing the "Reviewed-by" tag, will fix in v7.

On Tue, Aug 13, 2024 at 10:27:39AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Aug 13, 2024 at 6:37 AM Charles Wang <charles.goodix@gmail.com> wrote:
> >
> > The Goodix GT7986U touch controller report touch data according to the
> > HID protocol through the SPI bus. However, it is incompatible with
> > Microsoft's HID-over-SPI protocol.
> >
> > Signed-off-by: Charles Wang <charles.goodix@gmail.com>
> > ---
> >  .../bindings/input/goodix,gt7986u.yaml        | 71 +++++++++++++++++++
> >  1 file changed, 71 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml
> 
> As a point of reference, in v5 Conor gave you his "Reviewed-by" tag
> [1] despite having some nits. It's usually expected that you could fix
> the nits and carry the Reviewed-by tag on the next version unless you
> did something other than what was requested in review feedback.
> 
> [1] https://lore.kernel.org/all/20240618-affluent-unroasted-e6d5d34d1ea2@spud/

Thanks,

Charles

      reply	other threads:[~2024-08-14  2:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 13:36 [PATCH v6 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-08-13 13:36 ` [PATCH v6 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver Charles Wang
2024-08-13 17:26   ` Doug Anderson
2024-08-14  2:35     ` Charles Wang
2024-08-13 13:36 ` [PATCH v6 2/2] dt-bindings: input: Goodix SPI HID Touchscreen Charles Wang
2024-08-13 17:27   ` Doug Anderson
2024-08-14  2:37     ` Charles Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrwYXajn3a6R8VOm@ux-UP-WHL01 \
    --to=charles.goodix@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=conor@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hbarnor@chromium.org \
    --cc=jikos@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox