Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Wed 2024-10-02 13:01:05, Ilpo Järvinen wrote:
> On Wed, 2 Oct 2024, Pavel Machek wrote:
> 
> > Hi!
> > 
> > > > +static struct wmi_driver tuxedo_nb04_wmi_ab_driver = {
> > > > +	.driver = {
> > > > +		.name = "tuxedo_nb04_wmi_ab",
> > > > +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> > > > +	},
> > > > +	.id_table = tuxedo_nb04_wmi_ab_device_ids,
> > > > +	.probe = probe,
> > > > +	.remove = remove,
> > > > +	.no_singleton = true,
> > > > +};
> > > > +
> > > > +// We don't know if the WMI API is stable and how unique the GUID is for this ODM. To be on the safe
> > > > +// side we therefore only run this driver on tested devices defined by this list.
> > > 
> > > Please limit comment length to 80 chars and since you need multiple lines 
> > > here anyway, use the usual /* */ multiline comment formatting.
> > 
> > This driver needs to be split into generic part + hw specific part,
> > and reasonable kernel/user API needs to be defined for the generic
> > part. It is really too soon to tweak comment lengths.
> 
> Coding style is not something you add on top of everything after 
> everything else is done. It's much better to start with that right from 
> the beginning.

And yes, this driver leaves something to be desired.

OTOH if you comment on coding style only, it leaves impression of
"everything else is ok with this", which easily leads to wasted work
and frustration.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]