linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: hideep - add missing dependency on REGMAP_I2C
@ 2024-10-02 20:42 Javier Carrasco
  2024-10-03 11:46 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Javier Carrasco @ 2024-10-02 20:42 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Javier Carrasco

hideep makes use of regmap_i2c, and it has to be selected within its
Kconfig entry to compile successfully.

Fixes: 842ff286166e ("Input: add support for HiDeep touchscreen")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Building this module will fail at least with gcc-12/13 and a simple
.config that does not include REGMAP.
---
 drivers/input/touchscreen/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 1ac26fc2e3eb..601fa7ec2e8a 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -420,6 +420,7 @@ config TOUCHSCREEN_GOODIX_BERLIN_SPI
 config TOUCHSCREEN_HIDEEP
 	tristate "HiDeep Touch IC"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say Y here if you have a touchscreen using HiDeep.
 

---
base-commit: fe21733536749bb1b31c9c84e0b8d2ab8d82ce13
change-id: 20241002-input-hideep-select-remap-i2c-d785b9d677db

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: hideep - add missing dependency on REGMAP_I2C
  2024-10-02 20:42 [PATCH] Input: hideep - add missing dependency on REGMAP_I2C Javier Carrasco
@ 2024-10-03 11:46 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2024-10-03 11:46 UTC (permalink / raw)
  To: Javier Carrasco; +Cc: linux-input, linux-kernel

On Wed, Oct 02, 2024 at 10:42:30PM +0200, Javier Carrasco wrote:
> hideep makes use of regmap_i2c, and it has to be selected within its
> Kconfig entry to compile successfully.
> 
> Fixes: 842ff286166e ("Input: add support for HiDeep touchscreen")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-03 11:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 20:42 [PATCH] Input: hideep - add missing dependency on REGMAP_I2C Javier Carrasco
2024-10-03 11:46 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).