linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com, jikos@kernel.org, bentiss@kernel.org,
	dmitry.torokhov@gmail.com, linux-hyperv@vger.kernel.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	ernis@microsoft.com, rafael@kernel.org, pavel@ucw.cz,
	lenb@kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] Revert "HID: hyperv: register as a wakeup source"
Date: Tue, 24 Sep 2024 03:29:39 +0000	[thread overview]
Message-ID: <ZvIyI2N4V2rGABvh@csail.mit.edu> (raw)
In-Reply-To: <1726176470-13133-4-git-send-email-ernis@linux.microsoft.com>

[+linux-pm, Rafael, Len, Pavel]

On Thu, Sep 12, 2024 at 02:27:50PM -0700, Erni Sri Satya Vennela wrote:
> This reverts commit f1210455e78a610c7b316389b31c162c371d888c.
> 
> Remove mouse as wakeup source since Suspend-to-Idle feature
> is disabled.
> 
> Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
> ---
>  drivers/hid/hid-hyperv.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index f33485d83d24..b6d0f7db4c93 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -293,9 +293,6 @@ static void mousevsc_on_receive(struct hv_device *device,
>  		memcpy(input_dev->input_buf, input_report->buffer, len);
>  		hid_input_report(input_dev->hid_device, HID_INPUT_REPORT,
>  				 input_dev->input_buf, len, 1);
> -
> -		pm_wakeup_hard_event(&input_dev->device->device);
> -
>  		break;
>  	default:
>  		pr_err("unsupported hid msg type - type %d len %d\n",
> @@ -502,8 +499,6 @@ static int mousevsc_probe(struct hv_device *device,
>  		goto probe_err2;
>  	}
>  
> -	device_init_wakeup(&device->device, true);
> -
>  	input_dev->connected = true;
>  	input_dev->init_complete = true;
>  
> @@ -526,7 +521,6 @@ static void mousevsc_remove(struct hv_device *dev)
>  {
>  	struct mousevsc_dev *input_dev = hv_get_drvdata(dev);
>  
> -	device_init_wakeup(&dev->device, false);
>  	vmbus_close(dev->channel);
>  	hid_hw_stop(input_dev->hid_device);
>  	hid_destroy_device(input_dev->hid_device);
> -- 
> 2.34.1
> 
> 

  reply	other threads:[~2024-09-24  3:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 21:27 [PATCH 0/3] Disable Suspend-to-Idle in Hyper-V and Fix Hibernation Interruptions Erni Sri Satya Vennela
2024-09-12 21:27 ` [PATCH 1/3] Drivers: hv: vmbus: Disable Suspend-to-Idle for VMBus Erni Sri Satya Vennela
2024-09-13  6:38   ` Saurabh Singh Sengar
2024-09-13  7:19   ` Naman Jain
2024-09-21 19:09     ` Erni Sri Satya Vennela
2024-09-13 17:01   ` kernel test robot
2024-09-13 17:43   ` kernel test robot
2024-09-24  3:27   ` Srivatsa S. Bhat
2024-09-12 21:27 ` [PATCH 2/3] Revert "Input: hyperv-keyboard - register as a wakeup source" Erni Sri Satya Vennela
2024-09-24  3:28   ` Srivatsa S. Bhat
2024-10-04  8:14     ` Dmitry Torokhov
2024-10-17 13:44       ` Erni Sri Satya Vennela
2024-11-08 10:47         ` Erni Sri Satya Vennela
2024-12-09 17:16           ` Saurabh Singh Sengar
2024-12-12 14:33             ` Erni Sri Satya Vennela
2024-09-12 21:27 ` [PATCH 3/3] Revert "HID: hyperv: " Erni Sri Satya Vennela
2024-09-24  3:29   ` Srivatsa S. Bhat [this message]
2024-09-24  3:26 ` [PATCH 0/3] Disable Suspend-to-Idle in Hyper-V and Fix Hibernation Interruptions Srivatsa S. Bhat
2024-09-26  3:45   ` Erni Sri Satya Vennela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvIyI2N4V2rGABvh@csail.mit.edu \
    --to=srivatsa@csail.mit.edu \
    --cc=bentiss@kernel.org \
    --cc=decui@microsoft.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ernis@linux.microsoft.com \
    --cc=ernis@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=jikos@kernel.org \
    --cc=kys@microsoft.com \
    --cc=lenb@kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).