From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Charles Wang <charles.goodix@gmail.com>,
dianders@chromium.org, dan.carpenter@linaro.org,
conor@kernel.org, krzk+dt@kernel.org, bentiss@kernel.org,
hbarnor@chromium.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v7 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Date: Wed, 25 Sep 2024 14:57:08 -0700 [thread overview]
Message-ID: <ZvSHNFPPC1NNq33J@google.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2409252347140.31206@cbobk.fhfr.pm>
On Wed, Sep 25, 2024 at 11:48:50PM +0200, Jiri Kosina wrote:
> On Wed, 25 Sep 2024, Dmitry Torokhov wrote:
>
> > I see that Krzysztof sent a revert, but what a proper fix would be?
> > Apparently Goodix is using the same product ID gt7986u for both I2C and
> > SPI parts, and covering them in one binding is not really easy (well, I
> > guess it is possible with a big ugly "if"). Do we just slap "-spi"
> > suffix on the compatible, so it becomes "goodix,gt7986u-spi" and go on
> > on our merry way?
>
> I actually see this as a viable option, given the circumstances.
>
> However, given the non-responsiveness of the original author, I am now
> proceeding with the revert, and we can try to sort it out later.
Yeah, no objections there.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-09-25 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 2:45 [PATCH v7 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-08-14 2:45 ` [PATCH v7 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver Charles Wang
2024-08-14 2:45 ` [PATCH v7 2/2] dt-bindings: input: Goodix SPI HID Touchscreen Charles Wang
2024-09-06 20:28 ` Rob Herring
2024-09-10 22:41 ` Rob Herring
2024-09-25 17:40 ` Rob Herring
2024-09-25 20:51 ` Jiri Kosina
2024-09-25 21:45 ` Dmitry Torokhov
2024-09-25 21:48 ` Jiri Kosina
2024-09-25 21:57 ` Dmitry Torokhov [this message]
2024-09-26 1:51 ` Rob Herring
2024-09-26 4:54 ` Charles Wang
2024-08-19 19:17 ` [PATCH v7 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvSHNFPPC1NNq33J@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=hbarnor@chromium.org \
--cc=jikos@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).