From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Christopher Snowhill <kode54@gmail.com>
Cc: John Edwards <uejji@uejji.net>,
"Derek J . Clark" <derekjohn.clark@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] Input: xpad - add support for MSI Claw A1M
Date: Fri, 18 Oct 2024 14:36:50 -0700 [thread overview]
Message-ID: <ZxLU8s44Ffzf6nOC@google.com> (raw)
In-Reply-To: <D4SZUDRTK0LN.2I9S7T660S7IM@gmail.com>
Hi Christopher,
On Fri, Oct 11, 2024 at 05:59:42AM -0700, Christopher Snowhill wrote:
> On Thu Oct 10, 2024 at 4:09 PM PDT, John Edwards wrote:
> > Add MSI Claw A1M controller to xpad_device match table when in xinput mode.
> > Add MSI VID as XPAD_XBOX360_VENDOR.
> >
> > Signed-off-by: John Edwards <uejji@uejji.net>
> > Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com>
>
> Um, I may have erred with my contribution of a R-b? Do I have to test
> the patch on the device in question to review it? If so, I'll just Ack
> the patch as looking properly drafted, and applying cleanly. Sorry for
> the noise.
No, you do not need to test the patch to review it. We have a separate
"Tested-by" tag to signal when a person did test the patch with their
setup.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-10-18 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241010232020.3292284-2-uejji@uejji.net>
2024-10-10 23:09 ` [PATCH v1 1/1] Input: xpad - add support for MSI Claw A1M John Edwards
2024-10-11 11:28 ` Christopher Snowhill
2024-10-11 12:59 ` Christopher Snowhill
2024-10-18 21:36 ` Dmitry Torokhov [this message]
2024-10-18 21:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxLU8s44Ffzf6nOC@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=derekjohn.clark@gmail.com \
--cc=kode54@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uejji@uejji.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).