* [PATCH][next] Input: serio_raw: Fix uninitialized variable 'written'
@ 2024-10-21 14:41 Colin Ian King
2024-10-21 19:20 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-10-21 14:41 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: kernel-janitors, linux-kernel
The variable written is not initialized and subsequent increments of the
variable are using an uninitialized value. Fix this by initializating it
at the start of the function.
Fixes: 5b53a9d40c4f ("Input: serio_raw - use guard notation for locks and other resources")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/input/serio/serio_raw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index e058fef07f57..4d6395088986 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -185,7 +185,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer,
{
struct serio_raw_client *client = file->private_data;
struct serio_raw *serio_raw = client->serio_raw;
- int written;
+ int written = 0;
unsigned char c;
scoped_guard(mutex_intr, &serio_raw_mutex) {
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] Input: serio_raw: Fix uninitialized variable 'written'
2024-10-21 14:41 [PATCH][next] Input: serio_raw: Fix uninitialized variable 'written' Colin Ian King
@ 2024-10-21 19:20 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2024-10-21 19:20 UTC (permalink / raw)
To: Colin Ian King; +Cc: linux-input, kernel-janitors, linux-kernel
Hi Colin,
On Mon, Oct 21, 2024 at 03:41:03PM +0100, Colin Ian King wrote:
> The variable written is not initialized and subsequent increments of the
> variable are using an uninitialized value. Fix this by initializating it
> at the start of the function.
Thank you for the patch but I already have one fixing this up queued.
>
> Fixes: 5b53a9d40c4f ("Input: serio_raw - use guard notation for locks and other resources")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/input/serio/serio_raw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
> index e058fef07f57..4d6395088986 100644
> --- a/drivers/input/serio/serio_raw.c
> +++ b/drivers/input/serio/serio_raw.c
> @@ -185,7 +185,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer,
> {
> struct serio_raw_client *client = file->private_data;
> struct serio_raw *serio_raw = client->serio_raw;
> - int written;
> + int written = 0;
> unsigned char c;
>
> scoped_guard(mutex_intr, &serio_raw_mutex) {
> --
> 2.39.5
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-21 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 14:41 [PATCH][next] Input: serio_raw: Fix uninitialized variable 'written' Colin Ian King
2024-10-21 19:20 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).