From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/1] PCI: Move no_pci_devices() to the only driver using it
Date: Tue, 22 Oct 2024 13:45:00 -0700 [thread overview]
Message-ID: <ZxgOzHUqFDfBDedx@google.com> (raw)
In-Reply-To: <20241010194533.GA575181@bhelgaas>
Hi Bjorn, Ilpo,
On Thu, Oct 10, 2024 at 02:45:33PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 09, 2024 at 01:52:18PM +0300, Ilpo Järvinen wrote:
> > Core PCI code provides no_pci_devices() that is only used in the
> > pc110pad driver during init to detect cases when PC110 definitely cannot
> > be present. Move this legacy detection trickery/hack into the pc110pad
> > driver.
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Thanks, this is indeed a gross hack, and I'd be glad to eradicate it
> from PCI.
I would much rather remove pc110_pad altogether. If I can get a
"Reviewed-by" on [1] that would be great.
[1] https://lore.kernel.org/all/20240808172733.1194442-4-dmitry.torokhov@gmail.com/
Thanks.
--
Dmitry
prev parent reply other threads:[~2024-10-22 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 10:52 [PATCH 1/1] PCI: Move no_pci_devices() to the only driver using it Ilpo Järvinen
2024-10-10 19:45 ` Bjorn Helgaas
2024-10-22 20:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxgOzHUqFDfBDedx@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).