* [PATCH] Input: cs40l50 - Fix wrong usage of INIT_WORK()
@ 2024-11-06 1:35 Yuan Can
2024-11-08 6:09 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Yuan Can @ 2024-11-06 1:35 UTC (permalink / raw)
To: jogletre, fred.treven, ben.bright, dmitry.torokhov, jeff, lee,
patches, linux-input
Cc: yuancan
In cs40l50_add(), the work_data is a local variable and the work_data.work
should initialize with INIT_WORK_ONSTACK() instead of INIT_WORK().
Small error in cs40l50_erase() also fixed in this commit.
Fixes: c38fe1bb5d21 ("Input: cs40l50 - Add support for the CS40L50 haptic driver")
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
drivers/input/misc/cs40l50-vibra.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/cs40l50-vibra.c b/drivers/input/misc/cs40l50-vibra.c
index 03bdb7c26ec0..dce3b0ec8cf3 100644
--- a/drivers/input/misc/cs40l50-vibra.c
+++ b/drivers/input/misc/cs40l50-vibra.c
@@ -334,11 +334,12 @@ static int cs40l50_add(struct input_dev *dev, struct ff_effect *effect,
work_data.custom_len = effect->u.periodic.custom_len;
work_data.vib = vib;
work_data.effect = effect;
- INIT_WORK(&work_data.work, cs40l50_add_worker);
+ INIT_WORK_ONSTACK(&work_data.work, cs40l50_add_worker);
/* Push to the workqueue to serialize with playbacks */
queue_work(vib->vib_wq, &work_data.work);
flush_work(&work_data.work);
+ destroy_work_on_stack(&work_data.work);
kfree(work_data.custom_data);
@@ -467,11 +468,12 @@ static int cs40l50_erase(struct input_dev *dev, int effect_id)
work_data.vib = vib;
work_data.effect = &dev->ff->effects[effect_id];
- INIT_WORK(&work_data.work, cs40l50_erase_worker);
+ INIT_WORK_ONSTACK(&work_data.work, cs40l50_erase_worker);
/* Push to workqueue to serialize with playbacks */
queue_work(vib->vib_wq, &work_data.work);
flush_work(&work_data.work);
+ destroy_work_on_stack(&work_data.work);
return work_data.error;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: cs40l50 - Fix wrong usage of INIT_WORK()
2024-11-06 1:35 [PATCH] Input: cs40l50 - Fix wrong usage of INIT_WORK() Yuan Can
@ 2024-11-08 6:09 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2024-11-08 6:09 UTC (permalink / raw)
To: Yuan Can; +Cc: jogletre, fred.treven, ben.bright, jeff, lee, patches,
linux-input
On Wed, Nov 06, 2024 at 09:35:49AM +0800, Yuan Can wrote:
> In cs40l50_add(), the work_data is a local variable and the work_data.work
> should initialize with INIT_WORK_ONSTACK() instead of INIT_WORK().
> Small error in cs40l50_erase() also fixed in this commit.
>
> Fixes: c38fe1bb5d21 ("Input: cs40l50 - Add support for the CS40L50 haptic driver")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-08 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-06 1:35 [PATCH] Input: cs40l50 - Fix wrong usage of INIT_WORK() Yuan Can
2024-11-08 6:09 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).