* [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly
@ 2024-11-18 7:28 Wolfram Sang
2024-11-18 7:29 ` [PATCH 03/15] HID: google: " Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:28 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Alexander Shishkin, Alexandre Belloni, Andrew Lunn,
Andrew Lunn, AngeloGioacchino Del Regno, Armin Wolf,
Benjamin Tissoires, Bjorn Helgaas, Borislav Petkov,
Chandrashekar Devegowda, Chen-Yu Tsai, coresight, Dave Hansen,
David S. Miller, Dmitry Torokhov, Eric Dumazet, Florian Fainelli,
Greg Kroah-Hartman, Hans de Goede, Heikki Krogerus,
Heiner Kallweit, Ilpo Järvinen, Ingo Molnar, Jakub Kicinski,
Jernej Skrabec, Jiri Kosina, Len Brown, linux-arm-kernel,
linux-input, linux-mediatek, linux-media, linux-mmc, linux-pci,
linux-pm, linux-rtc, linux-sunxi, linux-usb, Loic Poulain,
Matthias Brugger, Mauro Carvalho Chehab, netdev, Paolo Abeni,
Pavel Machek, platform-driver-x86, Rafael J. Wysocki,
Samuel Holland, Sean Young, Sergey Ryazanov, Suzuki K Poulose,
Thomas Gleixner, Ulf Hansson, x86
While working on the wakeup functionality of a RTC driver, I noticed
that we have a few occasions where 'pm_wakeup.h' gets included directly
despite the comment that it shouldn't be done. It doesn't build-break
because these files also include 'device.h' either directly or via some
indirection, mostly 'platform_device.h'. Still, respect the requirement
that 'pm_wakeup.h' shall only be included in 'device.h' and not
directly.
Based on 6.12-rc7. Build-bot is happy and there are no dependencies. I
suggest that each patch goes in via the relevant subsystem tree.
Thanks and happy hacking,
Wolfram
Wolfram Sang (15):
x86/platform/olpc-xo1-sci: don't include 'pm_wakeup.h' directly
drivers core: don't include 'pm_wakeup.h' directly
HID: google: don't include 'pm_wakeup.h' directly
coresight: etm4x: don't include 'pm_wakeup.h' directly
Input: spear-keyboard - don't include 'pm_wakeup.h' directly
Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly
media: mceusb: don't include 'pm_wakeup.h' directly
mmc: core: don't include 'pm_wakeup.h' directly
net: phy: broadcom: don't include 'pm_wakeup.h' directly
net: wwan: t7xx: don't include 'pm_wakeup.h' directly
PCI: don't include 'pm_wakeup.h' directly
platform/x86: quickstart: don't include 'pm_wakeup.h' directly
rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly
usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly
PM / Sleep: don't include 'pm_wakeup.h' directly
arch/x86/platform/olpc/olpc-xo1-sci.c | 1 -
drivers/base/power/sysfs.c | 1 -
drivers/hid/hid-google-hammer.c | 1 -
drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
drivers/input/keyboard/spear-keyboard.c | 1 -
drivers/input/keyboard/sun4i-lradc-keys.c | 1 -
drivers/media/rc/mceusb.c | 1 -
drivers/mmc/core/core.c | 1 -
drivers/mmc/core/host.c | 1 -
drivers/net/phy/broadcom.c | 2 +-
drivers/net/wwan/t7xx/t7xx_pci.c | 1 -
drivers/pci/pci.c | 1 -
drivers/platform/x86/quickstart.c | 1 -
drivers/rtc/rtc-brcmstb-waketimer.c | 1 -
drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 -
kernel/power/autosleep.c | 1 -
16 files changed, 1 insertion(+), 16 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 03/15] HID: google: don't include 'pm_wakeup.h' directly
2024-11-18 7:28 [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly Wolfram Sang
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-18 9:58 ` Jiri Kosina
2024-11-18 7:29 ` [PATCH 05/15] Input: spear-keyboard - " Wolfram Sang
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys " Wolfram Sang
2 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Jiri Kosina, Benjamin Tissoires, linux-input
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/hid/hid-google-hammer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 22683ec819aa..1be4366f740f 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -22,7 +22,6 @@
#include <linux/platform_data/cros_ec_commands.h>
#include <linux/platform_data/cros_ec_proto.h>
#include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
#include <linux/unaligned.h>
#include "hid-ids.h"
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 05/15] Input: spear-keyboard - don't include 'pm_wakeup.h' directly
2024-11-18 7:28 [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly Wolfram Sang
2024-11-18 7:29 ` [PATCH 03/15] HID: google: " Wolfram Sang
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys " Wolfram Sang
2 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Dmitry Torokhov, linux-input
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/input/keyboard/spear-keyboard.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index 1df4feb8ba01..18417ba19fdb 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -20,7 +20,6 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
-#include <linux/pm_wakeup.h>
#include <linux/slab.h>
#include <linux/types.h>
#include <linux/platform_data/keyboard-spear.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 06/15] Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly
2024-11-18 7:28 [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly Wolfram Sang
2024-11-18 7:29 ` [PATCH 03/15] HID: google: " Wolfram Sang
2024-11-18 7:29 ` [PATCH 05/15] Input: spear-keyboard - " Wolfram Sang
@ 2024-11-18 7:29 ` Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
2 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2024-11-18 7:29 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Hans de Goede, Dmitry Torokhov, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, linux-input, linux-arm-kernel,
linux-sunxi
The header clearly states that it does not want to be included directly,
only via 'device.h'. 'platform_device.h' works equally well. Remove the
direct inclusion.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/input/keyboard/sun4i-lradc-keys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index f304cab0ebdb..9a4fdef2650e 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -24,7 +24,6 @@
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pm_wakeirq.h>
-#include <linux/pm_wakeup.h>
#include <linux/property.h>
#include <linux/regulator/consumer.h>
#include <linux/reset.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 03/15] HID: google: don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 03/15] HID: google: " Wolfram Sang
@ 2024-11-18 9:58 ` Jiri Kosina
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2024-11-18 9:58 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, Benjamin Tissoires, linux-input
On Mon, 18 Nov 2024, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Jiri Kosina <jkosina@suse.com>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/15] Input: spear-keyboard - don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 05/15] Input: spear-keyboard - " Wolfram Sang
@ 2024-11-20 5:36 ` Dmitry Torokhov
0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Torokhov @ 2024-11-20 5:36 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, linux-input
On Mon, Nov 18, 2024 at 08:29:04AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 06/15] Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys " Wolfram Sang
@ 2024-11-20 5:36 ` Dmitry Torokhov
0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Torokhov @ 2024-11-20 5:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Hans de Goede, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, linux-input, linux-arm-kernel, linux-sunxi
On Mon, Nov 18, 2024 at 08:29:05AM +0100, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-11-20 5:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-18 7:28 [PATCH 00/15] treewide: don't include 'pm_wakeup.h' directly Wolfram Sang
2024-11-18 7:29 ` [PATCH 03/15] HID: google: " Wolfram Sang
2024-11-18 9:58 ` Jiri Kosina
2024-11-18 7:29 ` [PATCH 05/15] Input: spear-keyboard - " Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
2024-11-18 7:29 ` [PATCH 06/15] Input: sun4i-lradc-keys " Wolfram Sang
2024-11-20 5:36 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).