From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Werner Sembach <wse@tuxedocomputers.com>,
hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v7 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices
Date: Thu, 17 Apr 2025 00:43:33 +0530 [thread overview]
Message-ID: <a03efee0-3470-4d7f-9a63-3ec9f1ae4f3a@oracle.com> (raw)
In-Reply-To: <20250416171809.557674-2-wse@tuxedocomputers.com>
On 16-04-2025 22:41, Werner Sembach wrote:
> + for (unsigned int i = 0; i < rep->lamp_count; ++i) {
> + if (rep->lamp_id[i] > driver_data->lamp_count) {
> + hid_dbg(hdev, "Out of bounds lamp_id in lamp_multi_update_report. Skippng whole report!\n");
> + return sizeof(*rep);
> + }
typo -Skippng
> +
> + for (unsigned int j = i + 1; j < rep->lamp_count; ++j) {
> + if (rep->lamp_id[i] == rep->lamp_id[j]) {
> + hid_dbg(hdev, "Duplicate lamp_id in lamp_multi_update_report. Skippng whole report!\n");
> + return sizeof(*rep);
> + }
> + }
> + }
Thanks,
Alok
next prev parent reply other threads:[~2025-04-16 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 17:11 [PATCH v7 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices Werner Sembach
2025-04-16 17:11 ` [PATCH v7 1/1] " Werner Sembach
2025-04-16 19:13 ` ALOK TIWARI [this message]
2025-04-16 19:25 ` Werner Sembach
2025-04-17 10:25 ` Ilpo Järvinen
2025-04-17 12:04 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a03efee0-3470-4d7f-9a63-3ec9f1ae4f3a@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=bentiss@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).