From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maximilian Luz Subject: Re: [RFC 0/2] Support for buttons on newer MS Surface devices Date: Sat, 1 Jun 2019 21:07:19 +0200 Message-ID: References: <20190516142523.117978-1-luzmaximilian@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190516142523.117978-1-luzmaximilian@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, Dmitry Torokhov , Hans de Goede , Chen Yu , Darren Hart , Andy Shevchenko List-Id: linux-input@vger.kernel.org Hi, any comments on this? I should also mention that this has been tested via https://github.com/jakeday/linux-surface. Maximilian On 5/16/19 4:25 PM, Maximilian Luz wrote: > This series adds suport for power and volume buttons on 5th and 6th > generation Microsoft Surface devices. Specifically, it adds support for > the power-button on the Surface Laptop 1 and Laptop 2, as well as > support for power- and (on-device) volume-buttons on the Surface Pro 5 > (2017), Pro 6, and Book 2. > > These devices use the same MSHW0040 device as on the Surface Pro 4, > however, whereas the Pro 4 uses an ACPI notify handler, the newer > devices use GPIO interrupts to signal these events. > > The first patch of this series ensures that the surfacepro3_button > driver, used for MSHW0040 on the Pro 4, does not probe for the newer > devices. The second patch adapts soc_button_array to implement the > actual button support. > > I think the changes to soc_button_array in the second patch warrant a > thorough review. I've tried to make things a bit more generic to be able > to integrate arbitrary ACPI GPIO power-/volume-button devices more > easily, I'm not sure if there may be reasons against this. > > Maximilian Luz (2): > platform: Fix device check for surfacepro3_button > input: soc_button_array for newer surface devices > > drivers/input/misc/soc_button_array.c | 134 ++++++++++++++++++++-- > drivers/platform/x86/surfacepro3_button.c | 38 ++++++ > 2 files changed, 160 insertions(+), 12 deletions(-) >