From: David Lechner <dlechner@baylibre.com>
To: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>,
jic23@kernel.org, srinivas.pandruvada@linux.intel.com,
bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: sensor-hub: Fix typo and improve documentation for sensor_hub_remove_callback()
Date: Thu, 1 May 2025 18:30:40 -0500 [thread overview]
Message-ID: <a355a23e-03d4-4f1e-977f-adab632c7c5c@baylibre.com> (raw)
In-Reply-To: <20250501231931.1865276-1-chelsyratnawat2001@gmail.com>
On 5/1/25 6:19 PM, Chelsy Ratnawat wrote:
> Changes in v2:
> - Improved the kernel-doc comment for sensor_hub_remove_callback().
> - Changed "Gyro" to "gyro".
> - Changed "usage ID" to "usage_id" for consistency with kernel-doc
> style.
> - Updated the comment to state that only one callback can be removed
> per (usage_id, hsdev) pair.
>
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
> ---
Normally people put the changes here below the --- rather than putting it in
the commit message.
Patch part looks good though.
Reviewed-by: David Lechner <dlechner@baylibre.com>
next prev parent reply other threads:[~2025-05-01 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 18:23 [PATCH] HID: sensor-hub: Fix typo and improve documentation for sensor_hub_remove_callback() Chelsy Ratnawat
2025-04-30 19:17 ` David Lechner
2025-05-01 23:21 ` srinivas pandruvada
[not found] ` <CAOeBcHOw6CHbY6W+wAWvYsm_CGRMCgt_BLSV65X=rnhuU1r1hw@mail.gmail.com>
2025-05-01 23:52 ` David Lechner
2025-05-01 23:19 ` [PATCH v2] " Chelsy Ratnawat
2025-05-01 23:30 ` David Lechner [this message]
2025-05-02 0:36 ` Chelsy Ratnawat
2025-05-04 16:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a355a23e-03d4-4f1e-977f-adab632c7c5c@baylibre.com \
--to=dlechner@baylibre.com \
--cc=bentiss@kernel.org \
--cc=chelsyratnawat2001@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).