Linux Input/HID development
 help / color / mirror / Atom feed
From: Sebastian Kropatsch <seb-dev@mail.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: input: Adding definitions for recovery and maskrom button?
Date: Sun, 9 Jun 2024 00:23:56 +0200	[thread overview]
Message-ID: <a4bed14a-ffa1-4985-bfd2-517999a8ca54@mail.de> (raw)

Hello!

Many Single Board Computers (SBCs), especially those based on Rockchip
SoCs, come with on-board buttons labeled "Recovery" (for entering some
recovery mode) and "MaskROM" (for entering MaskROM mode for software
flashing). These are usually GPIO-based keys or ADC attached resistor
ladder buttons.

When defining devicetrees for these boards, the current approaches
include e.g. using "linux,code = <KEY_VENDOR>;", <KEY_SETUP>,
<KEY_PROG2> or <BTN_1> if these butons are even defined in the
devicetree source. So basically, there is no common approach
currently, since a clearly defined key label is missing.

The "linux,code" symbols used in the .dts files come from
"include/uapi/linux/input-event-codes.h" which is included by
"#include <dt-bindings/input/input.h>".

Would it be a sensible approach to add two defines to input-event-codes.h
e.g. KEY_RECOVERY and KEY_MASKROM (or a more generalized name)? Or is
this out-of-scope for input-event-codes.h?

Please let me know. Thanks! I can send a patch if I get green light :)

In case you'd like to see examples of these buttons, you may have
a look at devices like FriendlyElec NanoPC T6 [1] or Orange Pi 5 Plus [2].


Cheers,
Sebastian

[1] https://wiki.friendlyelec.com/wiki/index.php/NanoPC-T6
[2] http://www.orangepi.org/orangepiwiki/index.php/Orange_Pi_5_Plus

                 reply	other threads:[~2024-06-08 22:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4bed14a-ffa1-4985-bfd2-517999a8ca54@mail.de \
    --to=seb-dev@mail.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox