From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872E3C43217 for ; Tue, 11 Oct 2022 12:15:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbiJKMPy (ORCPT ); Tue, 11 Oct 2022 08:15:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbiJKMPw (ORCPT ); Tue, 11 Oct 2022 08:15:52 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96FBA42E50 for ; Tue, 11 Oct 2022 05:15:46 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id o22so7903932qkl.8 for ; Tue, 11 Oct 2022 05:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pwx1gdCZLqXzaS+Q30irzvLhEizg6LXUuBfoqUklLTg=; b=dAZT5D1vT/7cmrauerfCRfjuzvHfg0ZeJ59e5GwTzvq/wxuQJK/jUSMIehrAUcKH1Y SUbKjjdU78SSMYzzJ3Lt25Tp5zrszTpOGc9HwdQSwHkecge5f1Rleoc4MU4kwkc7hjGq 5ywlPvgJJsuNlLoT+LDoRIDM8V0YUBirCTeMebmTihRzv4dmacx7P/Yf3NvzxuPwJcoN HjgwNzVGyOx0xLm46lB4E8P8fQBNwj5Fz/4+pVlGLZKy8nfOlKZf+kuZYGrmHuBad+RV nXT+HRy/I4kH7VpEu1I15YdrTUO3//0l2UtZ99vJW2yUtKw/NkDi2NhVs9hSkFabNpED Xwew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pwx1gdCZLqXzaS+Q30irzvLhEizg6LXUuBfoqUklLTg=; b=OEVByW7YpCZf1zto3XENfsmlx5AvIrv99RNooHAYekvKWkdaEe0+PXOuylikZwUjyn zO5opGYNz/51ONoONOm+4/cXn0orTRVtV/mvpxSfWJD0SkZIFSmuATRy0BwIDk1H+B6T 5sSA5v9ENtgo1+s3N8GwqCCJ8BSuy7Qv7it4f0i/gviE7gET8k2SMI6dj1ep0/TigiZy zhTuttn53sK7RhsxaL3f7/TWnLmHs+ieRc1URey2ob5sfebrtLSabrttEp4kWO+2wz4q pukFT0gt1FjohSB1ikMNszBwY+7z8FYWopb0ntweEpRWo/dVxurBSHhS5/SgO/p1YlNp IZEw== X-Gm-Message-State: ACrzQf3c1tDje8fSN/MVnK7T7cly+UTAsAMn7AnWmFHBVx2GHK/tDWDm M1TLZyYY/Px6OsNhkjq3C0NJYA== X-Google-Smtp-Source: AMsMyM4zqnKYzuwdSg60ltvydC2+eOl8VjiyscQMrqFRX6l5htyHRX178ctR3l//c91/L3BbNxWNsA== X-Received: by 2002:ae9:ec19:0:b0:6ea:d0cd:a4ed with SMTP id h25-20020ae9ec19000000b006ead0cda4edmr11194620qkg.472.1665490545744; Tue, 11 Oct 2022 05:15:45 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id k11-20020a05620a0b8b00b006cbc6e1478csm12398844qkh.57.2022.10.11.05.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 05:15:45 -0700 (PDT) Message-ID: Date: Tue, 11 Oct 2022 08:13:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v6 2/2] input: add Qualcomm SPMI haptics driver Content-Language: en-US To: Caleb Connolly Cc: Andy Gross , Bjorn Andersson , devicetree@vger.kernel.org, Dmitry Torokhov , Jeff LaBundy , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Rob Herring , Tom Rix References: <20221010162945.1325770-3-caleb@connolly.tech> From: Krzysztof Kozlowski In-Reply-To: <20221010162945.1325770-3-caleb@connolly.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 10/10/2022 12:30, Caleb Connolly wrote: > Add support for the haptics found in pmi8998 and related PMICs. > Based on the ff-memless interface. Currently this driver provides > a partial implementation of hardware features. > > This driver only supports LRAs (Linear Resonant Actuators) in the "buffer" > mode with a single wave pattern. > > Signed-off-by: Caleb Connolly > --- > drivers/input/misc/Kconfig | 15 + > drivers/input/misc/Makefile | 1 + > drivers/input/misc/qcom-pmi8998-haptics.c | 690 ++++++++++++++++++++++ > 3 files changed, 706 insertions(+) > create mode 100644 drivers/input/misc/qcom-pmi8998-haptics.c > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index a18ab7358d8f..c3b59ea23144 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -186,6 +186,21 @@ config INPUT_PMIC8XXX_PWRKEY > To compile this driver as a module, choose M here: the > module will be called pmic8xxx-pwrkey. > > +config INPUT_QCOM_PMI8998_HAPTICS > + tristate "Qualcomm SPMI HAPTICS" > + depends on ARCH_QCOM || COMPILE_TEST > + depends on MFD_PM8XXX || MFD_SPMI_PMIC || COMPILE_TEST (and actually test it) > + select INPUT_FF_MEMLESS > + help > + This option enables support for the haptics found in pmi8998 and > + related PMICs. Based on the ff-memless interface. > + > + This driver is for hardware too new for the INPUT_PM8XXX_VIBRATOR > + driver. > + > + To compile this driver as module, choose M here: the > + module will be called qcom_pmi8998_haptics. > + Best regards, Krzysztof