linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Filipe Laíns" <lains@archlinux.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming
Date: Fri, 05 Feb 2021 14:36:07 +0000	[thread overview]
Message-ID: <a80853410f48a7d29541c155bca1341bdd24a671.camel@archlinux.org> (raw)
In-Reply-To: <nycvar.YFH.7.76.2102051018370.28696@cbobk.fhfr.pm>

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

On Fri, 2021-02-05 at 10:18 +0100, Jiri Kosina wrote:
> On Sat, 30 Jan 2021, Filipe Laíns wrote:
> 
> > From: Filipe Laíns <lains@riseup.net>
> > 
> > In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
> > receiver that comes with the G602 device, but unfortunately I screwed up
> > during testing and it seems the keyboard events were actually not being
> > sent to userspace.
> > This resulted in keyboard events being broken in userspace, please
> > backport the fix.
> > 
> > The receiver uses the normal 0x01 Logitech keyboard report descriptor,
> > as expected, so it is just a matter of flagging it as supported.
> > 
> > Reported in
> > https://github.com/libratbag/libratbag/issues/1124
> > 
> > Signed-off-by: Filipe Laíns <lains@riseup.net>
> 
> Given this is a regression, could you please add proper Fixes: and Cc: 
> stable tags?
> 
> Thank you,
> 

Done :)
Sorry about that, I am not yet familiarized with all steps of the workflow.

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-02-05 22:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30 19:10 [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming Filipe Laíns
2021-01-30 19:14 ` Filipe Laíns
2021-01-30 19:29   ` Filipe Laíns
2021-01-30 20:27   ` Hans de Goede
2021-01-30 20:40     ` Filipe Laíns
2021-02-05  9:18 ` Jiri Kosina
2021-02-05 14:36   ` Filipe Laíns [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a80853410f48a7d29541c155bca1341bdd24a671.camel@archlinux.org \
    --to=lains@archlinux.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).