From: Oliver Graute <oliver.graute@kococonnector.com>
To: Purva Yeshi <purvayeshi550@gmail.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"yujiaoliang@vivo.com" <yujiaoliang@vivo.com>,
"jkeeping@inmusicbrands.com" <jkeeping@inmusicbrands.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] input: ili210x: Fix uninitialized symbols in ili251x_firmware_to_buffer
Date: Wed, 23 Apr 2025 07:30:18 +0000 [thread overview]
Message-ID: <aAiWvzzSSWraeRdr@graute-macos> (raw)
In-Reply-To: <20250419131315.24897-1-purvayeshi550@gmail.com>
On 19/04/25, Purva Yeshi wrote:
> Fix Smatch-detected issue:
>
> drivers/input/touchscreen/ili210x.c:621 ili251x_firmware_to_buffer()
> error: uninitialized symbol 'fw_addr'.
> drivers/input/touchscreen/ili210x.c:621 ili251x_firmware_to_buffer()
> error: uninitialized symbol 'fw_len'.
>
> Initialize 'fw_addr' and 'fw_len' to 0 in ili251x_firmware_to_buffer()
> to avoid uninitialized use warnings reported by smatch.
>
> Although the while loop ensures both variables are always assigned before
> use, initializing them silences false positives.
>
> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>
next prev parent reply other threads:[~2025-04-23 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 13:13 [PATCH] input: ili210x: Fix uninitialized symbols in ili251x_firmware_to_buffer Purva Yeshi
2025-04-23 7:30 ` Oliver Graute [this message]
2025-04-29 1:24 ` dmitry.torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAiWvzzSSWraeRdr@graute-macos \
--to=oliver.graute@kococonnector.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkeeping@inmusicbrands.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=purvayeshi550@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yujiaoliang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).