Re: [PATCH v3 1/6] dt-bindings: mfd: add pf1550

Krzysztof Kozlowski
2025-05-28T06:08:23Z

On 28/05/2025 00:25, Samuel Kayode via B4 Relay wrote:
> From: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
>
> Add a DT binding document for pf1550 PMIC. This describes the core mfd
> device along with its children: regulators, charger and onkey.
>
> Signed-off-by: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
> ---
> v3:
> - Address Krzysztof's feedback:
> - Fold charger and onkey objects
> - Drop compatible for sub-devices: onkey, charger and regulator.
> - Drop constant voltage property already included in
> monitored-battery
> - Fix whitespace warnings
> - Fix license
> v2:
> - Add yamls for the PMIC and the sub-devices
> ---
> Documentation/devicetree/bindings/mfd/pf1550.yaml | 139 ++++++++++++++++++++++

Filename: nothing improved.

> 1 file changed, 139 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/pf1550.yaml b/Documentation/devicetree/bindings/mfd/pf1550.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..7f22cb91eb5542c8aa616525ed1e78efa2a863d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/pf1550.yaml

...

> +
> + patternProperties:
> + "^(ldo[1-3]|sw[1-3]|vrefddr)$":
> + type: object
> + $ref: /schemas/regulator/regulator.yaml
> + description:
> + regulator configuration for ldo1-3, buck converters(sw1-3)
> + and DDR termination reference voltage (vrefddr)
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> + monitored-battery:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + A phandle to a monitored battery node that contains a valid value
> + for:
> + constant-charge-voltage-max-microvolt.
> +
> + fsl,thermal-regulation:

-celsius or whatever is in standard suffixes:
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

> + $ref: /schemas/types.yaml#/definitions/uint32

Drop

> + description:
> + Temperature threshold for thermal regulation of charger in celsius.

But this now makes me wonder whether this should be just part of thermal
zone and get the threshold from there. I assume this is temperature of
CHARGER, not the battery. If battery, you have such properties in
battery.yaml (monitored-batter).

@Sebastian,
Are there existing bindings or devices which regulate temperature based
on thermal-zones in DT?

> + enum: [ 60, 75, 90, 105 ]
> +
> + fsl,min-system-microvolt:
> + description:
> + System specific lower limit voltage.
> + enum: [ 3500000, 3700000, 4300000 ]
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + battery: battery-cell {
> + compatible = "simple-battery";
> + constant-charge-voltage-max-microvolt = <4400000>;
> + operating-range-celsius = <0 75>;

So this looks like duplicating thermal-regulation property.

> + };

Blank line

> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/input/linux-event-codes.h>

Includes go before battery-cell.

> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +

Best regards,
Krzysztof