Re: [PATCH v3 4/6] input: pf1550: add onkey support

kernel test robot
2025-05-28T16:23:30Z

Hi Samuel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 0a4b866d08c6adaea2f4592d31edac6deeb4dcbd]

url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Kayode-via-B4-Relay/dt-bindings-mfd-add-pf1550/20250528-062840
base: 0a4b866d08c6adaea2f4592d31edac6deeb4dcbd
patch link: https://lore.kernel.org/r/20250527-pf1550-v3-4-45f69453cd51%40savoirfairelinux.com
patch subject: [PATCH v3 4/6] input: pf1550: add onkey support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250529/202505290028.2lbquDkW-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250529/202505290028.2lbquDkW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505290028.2lbquDkW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/input/misc/pf1550-onkey.c:153:12: warning: 'pf1550_onkey_resume' defined but not used [-Wunused-function]
153 | static int pf1550_onkey_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/input/misc/pf1550-onkey.c:126:12: warning: 'pf1550_onkey_suspend' defined but not used [-Wunused-function]
126 | static int pf1550_onkey_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~

vim +/pf1550_onkey_resume +153 drivers/input/misc/pf1550-onkey.c

125
> 126 static int pf1550_onkey_suspend(struct device *dev)
127 {
128 struct platform_device *pdev = to_platform_device(dev);
129 struct onkey_drv_data *onkey = platform_get_drvdata(pdev);
130 struct irq_domain *domain;
131 unsigned int virq;
132 int i;
133
134 domain = regmap_irq_get_domain(onkey->pf1550->irq_data_onkey);
135
136 if (!device_may_wakeup(&pdev->dev)) {
137 regmap_write(onkey->pf1550->regmap,
138 PF1550_PMIC_REG_ONKEY_INT_MASK0,
139 ONKEY_IRQ_PUSHI | ONKEY_IRQ_1SI | ONKEY_IRQ_2SI |
140 ONKEY_IRQ_3SI | ONKEY_IRQ_4SI | ONKEY_IRQ_8SI);
141 } else {
142 for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) {
143 virq = irq_find_mapping(domain, i);
144
145 if (virq)
146 enable_irq_wake(virq);
147 }
148 }
149
150 return 0;
151 }
152
> 153 static int pf1550_onkey_resume(struct device *dev)
154 {
155 struct platform_device *pdev = to_platform_device(dev);
156 struct onkey_drv_data *onkey = platform_get_drvdata(pdev);
157 struct irq_domain *domain;
158 unsigned int virq;
159 int i;
160
161 domain = regmap_irq_get_domain(onkey->pf1550->irq_data_onkey);
162
163 if (!device_may_wakeup(&pdev->dev)) {
164 regmap_write(onkey->pf1550->regmap,
165 PF1550_PMIC_REG_ONKEY_INT_MASK0,
166 ~((u8)(ONKEY_IRQ_PUSHI | ONKEY_IRQ_1SI |
167 ONKEY_IRQ_2SI | ONKEY_IRQ_3SI | ONKEY_IRQ_4SI |
168 ONKEY_IRQ_8SI)));
169 } else {
170 for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) {
171 virq = irq_find_mapping(domain, i);
172
173 if (virq)
174 disable_irq_wake(virq);
175 }
176 }
177
178 return 0;
179 }
180

--
0-DAY CI Kernel Test Service