* [PATCH 2/3] HID: core: Add bus define for SoundWire bus
@ 2025-06-11 10:26 shumingf
2025-06-11 10:53 ` Charles Keepax
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: shumingf @ 2025-06-11 10:26 UTC (permalink / raw)
To: jikos, bentiss, broonie
Cc: linux-input, flove, oder_chiou, jack.yu, derek.fang, ckeepax,
bard.liao
From: Charles Keepax <ckeepax@opensource.cirrus.com>
SDCA (SoundWire Device Class for Audio) uses HID to convey
input events from peripheral devices. Add a bus define for the
SoundWire bus to prepare support for this.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/hid/hid-core.c | 3 +++
include/uapi/linux/input.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index b348d0464314..b419e31005b8 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2294,6 +2294,9 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask)
case BUS_I2C:
bus = "I2C";
break;
+ case BUS_SDW:
+ bus = "SOUNDWIRE";
+ break;
case BUS_VIRTUAL:
bus = "VIRTUAL";
break;
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index 2557eb7b0561..127119c287cf 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -275,6 +275,7 @@ struct input_mask {
#define BUS_CEC 0x1E
#define BUS_INTEL_ISHTP 0x1F
#define BUS_AMD_SFH 0x20
+#define BUS_SDW 0x21
/*
* MT_TOOL types
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] HID: core: Add bus define for SoundWire bus
2025-06-11 10:26 [PATCH 2/3] HID: core: Add bus define for SoundWire bus shumingf
@ 2025-06-11 10:53 ` Charles Keepax
2025-06-11 10:55 ` Charles Keepax
2025-06-13 11:41 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2025-06-11 10:53 UTC (permalink / raw)
To: shumingf
Cc: jikos, bentiss, broonie, linux-input, flove, oder_chiou, jack.yu,
derek.fang, bard.liao
On Wed, Jun 11, 2025 at 06:26:50PM +0800, shumingf@realtek.com wrote:
> From: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> SDCA (SoundWire Device Class for Audio) uses HID to convey
> input events from peripheral devices. Add a bus define for the
> SoundWire bus to prepare support for this.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
You should add your own signed-off here as well as you are
sending the patch.
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] HID: core: Add bus define for SoundWire bus
2025-06-11 10:26 [PATCH 2/3] HID: core: Add bus define for SoundWire bus shumingf
2025-06-11 10:53 ` Charles Keepax
@ 2025-06-11 10:55 ` Charles Keepax
2025-06-13 11:41 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2025-06-11 10:55 UTC (permalink / raw)
To: shumingf
Cc: jikos, bentiss, broonie, linux-input, flove, oder_chiou, jack.yu,
derek.fang, bard.liao, pierre-louis.bossart
On Wed, Jun 11, 2025 at 06:26:50PM +0800, shumingf@realtek.com wrote:
Adding Pierre.
> From: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> SDCA (SoundWire Device Class for Audio) uses HID to convey
> input events from peripheral devices. Add a bus define for the
> SoundWire bus to prepare support for this.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/hid/hid-core.c | 3 +++
> include/uapi/linux/input.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index b348d0464314..b419e31005b8 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2294,6 +2294,9 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask)
> case BUS_I2C:
> bus = "I2C";
> break;
> + case BUS_SDW:
> + bus = "SOUNDWIRE";
> + break;
> case BUS_VIRTUAL:
> bus = "VIRTUAL";
> break;
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index 2557eb7b0561..127119c287cf 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -275,6 +275,7 @@ struct input_mask {
> #define BUS_CEC 0x1E
> #define BUS_INTEL_ISHTP 0x1F
> #define BUS_AMD_SFH 0x20
> +#define BUS_SDW 0x21
>
> /*
> * MT_TOOL types
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] HID: core: Add bus define for SoundWire bus
2025-06-11 10:26 [PATCH 2/3] HID: core: Add bus define for SoundWire bus shumingf
2025-06-11 10:53 ` Charles Keepax
2025-06-11 10:55 ` Charles Keepax
@ 2025-06-13 11:41 ` Mark Brown
2025-06-16 2:17 ` Shuming [范書銘]
2 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2025-06-13 11:41 UTC (permalink / raw)
To: shumingf
Cc: jikos, bentiss, linux-input, flove, oder_chiou, jack.yu,
derek.fang, ckeepax, bard.liao
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
On Wed, Jun 11, 2025 at 06:26:50PM +0800, shumingf@realtek.com wrote:
> From: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> SDCA (SoundWire Device Class for Audio) uses HID to convey
> input events from peripheral devices. Add a bus define for the
> SoundWire bus to prepare support for this.
Patch 3 depends on this one and it seems fairly straightforward - it
seems like it'd make sense to take it through the ASoC tree?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/3] HID: core: Add bus define for SoundWire bus
2025-06-13 11:41 ` Mark Brown
@ 2025-06-16 2:17 ` Shuming [范書銘]
0 siblings, 0 replies; 5+ messages in thread
From: Shuming [范書銘] @ 2025-06-16 2:17 UTC (permalink / raw)
To: Mark Brown
Cc: jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org,
Flove(HsinFu), Oder Chiou, Jack Yu,
Derek [方德義], ckeepax@opensource.cirrus.com,
bard.liao@intel.com
> > SDCA (SoundWire Device Class for Audio) uses HID to convey input
> > events from peripheral devices. Add a bus define for the SoundWire bus
> > to prepare support for this.
>
> Patch 3 depends on this one and it seems fairly straightforward - it seems like
> it'd make sense to take it through the ASoC tree?
Agreed. I will send this series to the ASoC tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-16 2:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-11 10:26 [PATCH 2/3] HID: core: Add bus define for SoundWire bus shumingf
2025-06-11 10:53 ` Charles Keepax
2025-06-11 10:55 ` Charles Keepax
2025-06-13 11:41 ` Mark Brown
2025-06-16 2:17 ` Shuming [范書銘]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).