From: Tomas Jurena <jurenatomas@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: dmitry.torokhov@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation
Date: Wed, 11 Jun 2025 18:08:07 +0200 [thread overview]
Message-ID: <aEmp57H3Tk6DnJty@jurenat-workstationFai> (raw)
In-Reply-To: <20250610181542.GA2396962-robh@kernel.org>
On Tue, Jun 10, 2025 at 01:15:42PM -0500, Rob Herring wrote:
> On Tue, Jun 10, 2025 at 05:46:10PM +0200, Tomáš Juřena wrote:
> > From: Tomas Jurena <jurenatomas@gmail.com>
> >
> > Adds support for instantiating the tca6416-keypad driver via
> > Device Tree. If no platform data is present, the driver can now be
> > probed based on OF bindings.
> >
> > A corresponding Device Tree binding document is added at:
> > Documentation/devicetree/bindings/input/tca6416-keypad.yaml
> >
> > This allows the driver to be used in systems that rely solely on the
> > Device Tree for hardware description, such as embedded ARM platforms.
> >
> > Tested on Toradex Ixora 1.3A board and Apalis imx8 SOM.
>
> We already have a GPIO driver for this chip. Would the
> gpio-keys driver work here instead? Seems to work for
> arch/arm/boot/dts/ti/omap/am3517-evm-ui.dtsi.
>
I was not aware of this. Anyway, I tested this today, and it seems to work just fine with my hardware. There is no need for this change from my side.
next prev parent reply other threads:[~2025-06-11 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 15:46 [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation Tomáš Juřena
2025-06-10 17:37 ` Rob Herring (Arm)
2025-06-10 18:15 ` Rob Herring
2025-06-11 16:08 ` Tomas Jurena [this message]
2025-06-11 17:44 ` Dmitry Torokhov
2025-06-11 14:22 ` kernel test robot
2025-06-18 17:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEmp57H3Tk6DnJty@jurenat-workstationFai \
--to=jurenatomas@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox