Re: [PATCH v3 1/4] gpiolib: acpi: Add a helper for programming debounce

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Jun 25, 2025 at 04:58:10PM -0500, Mario Limonciello wrote:
> 
> Debounce is programmed in two places and considered non-fatal in one of
> them. Introduce a helper for programming debounce and show a warning
> when failing to program.

> This is a difference in behavior for the call
> in acpi_dev_gpio_irq_wake_get_by().

When I meant "both", I was thinking of the _single_ existing case and new one
which you are about to add. In principle, I think changing behaviour here is
undesired. We provoke BIOS writers to make mistakes with debounce settings in
GpioInt() resources.

I agree on the patch...

> -			/* ACPI uses hundredths of milliseconds units */
> -			ret = gpio_set_debounce_timeout(desc, info.debounce * 10);
> -			if (ret)
> -				return ret;
> +			acpi_set_debounce_timeout(desc, info.debounce);

...except this hunk.

-- 
With Best Regards,
Andy Shevchenko