From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Vicki Pfau <vi@endrift.com>,
Benjamin Tissoires <bentiss@kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Fix debug name for BTN_GEAR_DOWN, BTN_GEAR_UP, BTN_WHEEL
Date: Thu, 10 Jul 2025 12:34:18 +0300 [thread overview]
Message-ID: <aG-JGoafBiqvJpiX@black.fi.intel.com> (raw)
In-Reply-To: <r8831n3q-n077-p703-p73n-9o981r077rp4@xreary.bet>
On Thu, Jul 03, 2025 at 09:44:54AM +0200, Jiri Kosina wrote:
> On Tue, 1 Jul 2025, Vicki Pfau wrote:
>
> > The name of BTN_GEAR_DOWN was WheelBtn and BTN_WHEEL was missing. Further,
> > BTN_GEAR_UP had a space in its name and no Btn, which is against convention.
> > This makes the names BtnGearDown, BtnGearUp, and BtnWheel, fixing the errors
> > and matching convention.
> >
> > Signed-off-by: Vicki Pfau <vi@endrift.com>
>
> Applied to hid.git#for-6.16/upstream-fixes. Thanks,
Too quick. This breaks the build.
drivers/hid/hid-debug.c:3302:16: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
3302 | [BTN_WHEEL] = "BtnWheel", [KEY_OK] = "Ok",
| ^~~~~~~~~~
drivers/hid/hid-debug.c:3301:20: note: previous initialization is here
3301 | [BTN_GEAR_DOWN] = "BtnGearDown", [BTN_GEAR_UP] = "BtnGearUp",
| ^~~~~~~~~~~~~
1 error generated.
Please, guys, always test your builds with `make W=1` (when CONFIG_WERROR is
not dropped) and with GCC and clang.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-10 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 3:46 [PATCH] HID: Fix debug name for BTN_GEAR_DOWN, BTN_GEAR_UP, BTN_WHEEL Vicki Pfau
2025-07-03 7:44 ` Jiri Kosina
2025-07-10 9:34 ` Andy Shevchenko [this message]
2025-07-10 9:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG-JGoafBiqvJpiX@black.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=vi@endrift.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox