From: Samuel Kayode <samuel.kayode@savoirfairelinux.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sebastian Reichel <sre@kernel.org>, Frank Li <Frank.li@nxp.com>,
imx@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-pm@vger.kernel.org, Abel Vesa <abelvesa@kernel.org>,
Abel Vesa <abelvesa@linux.com>, Robin Gong <b38343@freescale.com>,
Robin Gong <yibin.gong@nxp.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>
Subject: Re: [PATCH v8 2/6] mfd: pf1550: add core driver
Date: Thu, 10 Jul 2025 13:11:07 -0400 [thread overview]
Message-ID: <aG_0K2qN06JHS0__@fedora> (raw)
In-Reply-To: <idqtxdptxq6s57r452staq3xv6zzs3i5bbapzxdlu3o7cdahaq@j257j4okrw52>
On Thu, Jul 10, 2025 at 02:54:38PM +0000, Sean Nyekjaer wrote:
> > + /* Regulator DVS */
> > + ret = pf1550_read_otp(pf1550, PF1550_OTP_SW2_SW3, &otp_data);
> > + if (ret)
> > + return ret;
> > +
> > + /* When clear, DVS should be enabled */
> > + if (!(otp_data & OTP_DVS_ENB))
> > + pf1550->dvs_enb = true;
> > +
>
> Thanks for upstreaming this :)
>
> We need to handle DVS for SW1 here.
> I'm using the A6 variant that have DVS enabled for SW1 and disabled for
> SW2.
> The A1 variant have DVS for SW1 disabled...
I can add checking of the OTP for SW1 in the next patchset.
Thanks,
Sam
next prev parent reply other threads:[~2025-07-10 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 21:37 [PATCH v8 0/6] add support for pf1550 PMIC MFD-based drivers Samuel Kayode via B4 Relay
2025-07-07 21:37 ` [PATCH v8 1/6] dt-bindings: mfd: add pf1550 Samuel Kayode via B4 Relay
2025-07-07 21:37 ` [PATCH v8 2/6] mfd: pf1550: add core driver Samuel Kayode via B4 Relay
2025-07-08 18:46 ` Christophe JAILLET
2025-07-10 14:08 ` Samuel Kayode
2025-07-10 14:54 ` Sean Nyekjaer
2025-07-10 17:11 ` Samuel Kayode [this message]
2025-07-07 21:37 ` [PATCH v8 3/6] regulator: pf1550: add support for regulator Samuel Kayode via B4 Relay
2025-07-10 14:49 ` Sean Nyekjaer
2025-07-10 17:01 ` Samuel Kayode
2025-07-10 17:11 ` Sean Nyekjaer
2025-07-10 17:29 ` Samuel Kayode
2025-07-11 10:04 ` Sean Nyekjaer
2025-07-07 21:37 ` [PATCH v8 4/6] input: pf1550: add onkey support Samuel Kayode via B4 Relay
2025-07-11 10:29 ` Sean Nyekjaer
2025-07-07 21:37 ` [PATCH v8 5/6] power: supply: pf1550: add battery charger support Samuel Kayode via B4 Relay
2025-07-11 9:02 ` Sean Nyekjaer
2025-07-11 16:27 ` Samuel Kayode
2025-07-07 21:37 ` [PATCH v8 6/6] MAINTAINERS: add an entry for pf1550 mfd driver Samuel Kayode via B4 Relay
2025-07-10 17:06 ` Samuel Kayode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG_0K2qN06JHS0__@fedora \
--to=samuel.kayode@savoirfairelinux.com \
--cc=Frank.li@nxp.com \
--cc=abelvesa@kernel.org \
--cc=abelvesa@linux.com \
--cc=b38343@freescale.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sean@geanix.com \
--cc=sre@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).