public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: "José Expósito" <jose.exposito89@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: bentiss@kernel.org, luguohong@xiaomi.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] HID: input: report battery status changes immediately
Date: Thu, 14 Aug 2025 12:43:02 +0200	[thread overview]
Message-ID: <aJ29tlqoQYFa-WYt@fedora> (raw)
In-Reply-To: <4q4qn3p8-6s3s-289n-44s2-43s76qrs2oo4@xreary.bet>

Hi Jiri,

On Mon, Aug 11, 2025 at 01:48:22PM +0200, Jiri Kosina wrote:
> On Wed, 6 Aug 2025, José Expósito wrote:
> 
> > When the battery status changes, report the change immediately to user
> > space.
> 
> Could you please make the changelog a little bit more elaborative, i.e. 
> why is it needed, what user-visible behavior change/improvement it brings, 
> etc.
> 
> I know it's in the e-mail thread, but at least some summary should go also 
> to the commit itself.

Thanks a lot for reviewing these patches.

I sent v3 with a more detailed description of the fix:
https://lore.kernel.org/linux-input/20250814103947.116139-1-jose.exposito89@gmail.com/

Jose

> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 

  parent reply	other threads:[~2025-08-14 10:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-06  7:39 [PATCH v2 1/2] HID: input: rename hidinput_set_battery_charge_status() José Expósito
2025-08-06  7:39 ` [PATCH v2 2/2] HID: input: report battery status changes immediately José Expósito
     [not found]   ` <726471d1e4774348bd62ecf289a5a307@xiaomi.com>
2025-08-11 10:30     ` 答复: [External Mail][PATCH " José Expósito
2025-08-11 11:48   ` [PATCH " Jiri Kosina
     [not found]     ` <6c923b9403bb45988f211cae45e4f748@xiaomi.com>
2025-08-14  9:30       ` 答复: [External Mail]Re: " 卢国宏
2025-08-14 10:43     ` José Expósito [this message]
2025-08-18  0:52       ` 卢国宏

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJ29tlqoQYFa-WYt@fedora \
    --to=jose.exposito89@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luguohong@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox