From: "Leo L. Schwab" <ewhac@ewhac.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Hans de Goede <hansg@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Kate Hsuan <hpa@redhat.com>,
oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH] HID: lg-g15 - Add support for Logitech G13.
Date: Mon, 11 Aug 2025 23:51:34 -0700 [thread overview]
Message-ID: <aJrkdqrCG2FQZr53@ewhac.org> (raw)
In-Reply-To: <202508120615.TGJUom52-lkp@intel.com> <d37e7ccd-1d5d-4237-8a7e-a0eb10ec069d@web.de> <92a3486e-f101-4ca4-a611-a5c1c6afa6ca@web.de>
On Mon, Aug 11, 2025 at 07:00:24PM +0200, Markus Elfring wrote:
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
>
On Mon, Aug 11, 2025 at 07:10:46PM +0200, Markus Elfring wrote:
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&g15->mutex);”?
> https://elixir.bootlin.com/linux/v6.16/source/include/linux/mutex.h#L225
>
On Tue, Aug 12, 2025 at 08:00:09AM +0800, kernel test robot wrote:
> kernel test robot noticed the following build errors:
> [ ... ]
> drivers/hid/hid-lg-g15.c: In function 'lg_g13_event':
> >> drivers/hid/hid-lg-g15.c:703:68: error: 'struct led_classdev' has no member named 'brightness_hw_changed'
> 703 | (!!TEST_BIT(rep->keybits, 23)) ^ (g15->leds[0].cdev.brightness_hw_changed > 0);
> | ^
>
Thank you. Updated patch forthcoming which will hopefully address
these concerns.
Schwab
next prev parent reply other threads:[~2025-08-12 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 22:56 [PATCH] HID: lg-g15 - Add support for Logitech G13 Leo L. Schwab
2025-08-11 17:00 ` Markus Elfring
2025-08-12 6:51 ` Leo L. Schwab [this message]
2025-08-11 17:10 ` Markus Elfring
2025-08-12 0:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJrkdqrCG2FQZr53@ewhac.org \
--to=ewhac@ewhac.org \
--cc=Markus.Elfring@web.de \
--cc=bentiss@kernel.org \
--cc=hansg@kernel.org \
--cc=hpa@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox