* [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
@ 2025-09-23 4:02 Abhishek Tamboli
2025-09-24 3:31 ` Xu, Even
0 siblings, 1 reply; 3+ messages in thread
From: Abhishek Tamboli @ 2025-09-23 4:02 UTC (permalink / raw)
To: even.xu, xinpeng.sun, jikos, bentiss
Cc: mpearson-lenovo, srinivas.pandruvada, linux-input, linux-kernel
Add the missing PCI ID for the quickspi device used on
the Lenovo Yoga Pro 9i 16IAH10.
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=220567
Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 6 ++++++
drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
index 84314989dc53..49c8458f0118 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
@@ -33,6 +33,10 @@ struct quickspi_driver_data ptl = {
.max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL,
};
+struct quickspi_driver_data arl = {
+ .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL,
+};
+
/* THC QuickSPI ACPI method to get device properties */
/* HIDSPI Method: {6e2ac436-0fcf-41af-a265-b32a220dcfab} */
static guid_t hidspi_guid =
@@ -978,6 +982,8 @@ static const struct pci_device_id quickspi_pci_tbl[] = {
{PCI_DEVICE_DATA(INTEL, THC_PTL_U_DEVICE_ID_SPI_PORT2, &ptl), },
{PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_SPI_PORT1, &ptl), },
{PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_SPI_PORT2, &ptl), },
+ {PCI_DEVICE_DATA(INTEL, THC_ARL_DEVICE_ID_SPI_PORT1, &arl), },
+ {PCI_DEVICE_DATA(INTEL, THC_ARL_DEVICE_ID_SPI_PORT2, &arl), },
{}
};
MODULE_DEVICE_TABLE(pci, quickspi_pci_tbl);
diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
index f3532d866749..7f0fb0056244 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
@@ -21,6 +21,8 @@
#define PCI_DEVICE_ID_INTEL_THC_PTL_U_DEVICE_ID_SPI_PORT2 0xE44B
#define PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_SPI_PORT1 0x4D49
#define PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_SPI_PORT2 0x4D4B
+#define PCI_DEVICE_ID_INTEL_THC_ARL_DEVICE_ID_SPI_PORT1 0x7749
+#define PCI_DEVICE_ID_INTEL_THC_ARL_DEVICE_ID_SPI_PORT2 0x774B
/* HIDSPI special ACPI parameters DSM methods */
#define ACPI_QUICKSPI_REVISION_NUM 2
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
2025-09-23 4:02 [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's Abhishek Tamboli
@ 2025-09-24 3:31 ` Xu, Even
2025-09-24 4:09 ` Abhishek Tamboli
0 siblings, 1 reply; 3+ messages in thread
From: Xu, Even @ 2025-09-24 3:31 UTC (permalink / raw)
To: Abhishek Tamboli, Sun, Xinpeng, jikos@kernel.org,
bentiss@kernel.org
Cc: mpearson-lenovo@squebb.ca, srinivas.pandruvada@linux.intel.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Abhishek Tamboli <abhishektamboli9@gmail.com>
> Sent: Tuesday, September 23, 2025 12:03 PM
> To: Xu, Even <even.xu@intel.com>; Sun, Xinpeng <xinpeng.sun@intel.com>;
> jikos@kernel.org; bentiss@kernel.org
> Cc: mpearson-lenovo@squebb.ca; srinivas.pandruvada@linux.intel.com; linux-
> input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
>
> Add the missing PCI ID for the quickspi device used on the Lenovo Yoga Pro 9i
> 16IAH10.
>
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=220567
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 6 ++++++
> drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> index 84314989dc53..49c8458f0118 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> @@ -33,6 +33,10 @@ struct quickspi_driver_data ptl = {
> .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL, };
>
> +struct quickspi_driver_data arl = {
> + .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL, };
> +
As I know the THC IP in ARL is the same with in MTL, can you change this max_packet_size_value to align with MAX_PACKET_SIZE_VALUE_MTL?
Thanks!
> /* THC QuickSPI ACPI method to get device properties */
> /* HIDSPI Method: {6e2ac436-0fcf-41af-a265-b32a220dcfab} */ static guid_t
> hidspi_guid = @@ -978,6 +982,8 @@ static const struct pci_device_id
> quickspi_pci_tbl[] = {
> {PCI_DEVICE_DATA(INTEL, THC_PTL_U_DEVICE_ID_SPI_PORT2, &ptl), },
> {PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_SPI_PORT1, &ptl), },
> {PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_SPI_PORT2, &ptl), },
> + {PCI_DEVICE_DATA(INTEL, THC_ARL_DEVICE_ID_SPI_PORT1, &arl), },
> + {PCI_DEVICE_DATA(INTEL, THC_ARL_DEVICE_ID_SPI_PORT2, &arl), },
> {}
> };
> MODULE_DEVICE_TABLE(pci, quickspi_pci_tbl); diff --git a/drivers/hid/intel-thc-
> hid/intel-quickspi/quickspi-dev.h b/drivers/hid/intel-thc-hid/intel-
> quickspi/quickspi-dev.h
> index f3532d866749..7f0fb0056244 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
> @@ -21,6 +21,8 @@
> #define PCI_DEVICE_ID_INTEL_THC_PTL_U_DEVICE_ID_SPI_PORT2
> 0xE44B
> #define PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_SPI_PORT1
> 0x4D49
> #define PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_SPI_PORT2
> 0x4D4B
> +#define PCI_DEVICE_ID_INTEL_THC_ARL_DEVICE_ID_SPI_PORT1
> 0x7749
> +#define PCI_DEVICE_ID_INTEL_THC_ARL_DEVICE_ID_SPI_PORT2
> 0x774B
>
> /* HIDSPI special ACPI parameters DSM methods */
> #define ACPI_QUICKSPI_REVISION_NUM 2
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
2025-09-24 3:31 ` Xu, Even
@ 2025-09-24 4:09 ` Abhishek Tamboli
0 siblings, 0 replies; 3+ messages in thread
From: Abhishek Tamboli @ 2025-09-24 4:09 UTC (permalink / raw)
To: Xu, Even
Cc: xinpeng.sun, jikos, bentiss, mpearson-lenovo, srinivas.pandruvada,
linux-input, linux-kernel
On Wed, Sep 24, 2025 at 03:31:33AM +0000, Xu, Even wrote:
>
>
> > -----Original Message-----
> > From: Abhishek Tamboli <abhishektamboli9@gmail.com>
> > Sent: Tuesday, September 23, 2025 12:03 PM
> > To: Xu, Even <even.xu@intel.com>; Sun, Xinpeng <xinpeng.sun@intel.com>;
> > jikos@kernel.org; bentiss@kernel.org
> > Cc: mpearson-lenovo@squebb.ca; srinivas.pandruvada@linux.intel.com; linux-
> > input@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
> >
> > Add the missing PCI ID for the quickspi device used on the Lenovo Yoga Pro 9i
> > 16IAH10.
> >
> > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=220567
> >
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> > ---
> > drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 6 ++++++
> > drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h | 2 ++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > index 84314989dc53..49c8458f0118 100644
> > --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > @@ -33,6 +33,10 @@ struct quickspi_driver_data ptl = {
> > .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL, };
> >
> > +struct quickspi_driver_data arl = {
> > + .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL, };
> > +
>
> As I know the THC IP in ARL is the same with in MTL, can you change this max_packet_size_value to align with MAX_PACKET_SIZE_VALUE_MTL?
Sure, I will do it.
Thanks, for the review.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-24 4:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-23 4:02 [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's Abhishek Tamboli
2025-09-24 3:31 ` Xu, Even
2025-09-24 4:09 ` Abhishek Tamboli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).